fix[venom]: uninitialized mem after mem2var#4841
Open
HodanPlodky wants to merge 5 commits intovyperlang:masterfrom
Open
fix[venom]: uninitialized mem after mem2var#4841HodanPlodky wants to merge 5 commits intovyperlang:masterfrom
HodanPlodky wants to merge 5 commits intovyperlang:masterfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #4841 +/- ##
==========================================
- Coverage 92.89% 92.88% -0.01%
==========================================
Files 155 157 +2
Lines 21744 21912 +168
Branches 3885 3929 +44
==========================================
+ Hits 20199 20353 +154
- Misses 1024 1029 +5
- Partials 521 530 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
is this generated by vyper code? or is the example handcrafted venom i think that for unallocated memory, the assumption that the first read returns 0 is not true, if the allocator has given it a memory space which was previously written to already |
📊 Bytecode Size Changes (venom)No changes detected. Full bytecode sizes
|
Member
|
like it should be an error to try to read alloca space before it has been written to, no? |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| try: | ||
| checker.run_passes(pre, pre) | ||
| except CompilerPanic: |
Check notice
Code scanning / CodeQL
Empty except Note test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Fixed problem with
Mem2Varpass where if the value is read before written for the first time the semantics with memory would be to return 0. This was not reflected after the pass. To achieve this I added the initial assign to variable.Before mem2var:
After mem2var and makessa:
How I did it
How to verify it
Commit message
Added initial assign to the
Mem2Varpass for cases where it would be necessary to read from uninitialized memory.Description for the changelog
Cute Animal Picture