OpenSSL 1.1 compatibility

[pollolobo]

Resolves tg issue #1248 / #1256 by accessing opaque structures as advised in https://wiki.openssl.org/index.php/1.1_API_Changes

[BenWiederhake]

Thanks! I vaguely remember having to hack together a lot of things so that all structures end up being opaque to the rest of tgl. Most of the changes are pretty reasonable and look like they're exclusively due to the API change.

I'd like to ask a few things though:

• This repo is mostly dead. For telegram-purple, which depends on tgl, we kinda-maintain a fork, so could you please open a PR there, too?
• Why retain #define RSA_GETTER(M)? That was just there to remove code duplication.
• Why the empty lines? (Specifically, lines 82, 96, 100, 107, 121.) Is it a typo, or is there some black magic going on?

Other than that, it looks good to me. Again, thanks for the effort and sharing!

[pollolobo]

Thank you!
I have removed the commented out lines and the spaces and I'm opening the PR in a minute.

[regalstreak]

Works great. Thanks! +2

[matthiasbock]

@vysheng This PR has been open for a while now and fixes a problem, that is still relevant. Is there a reason, why it has not been merged yet? I'm just curious, if I can maybe help out.

[BenWiederhake]

Have you seen @vysheng around this year? Anywhere? Me neither. That's why.

He's busy with life, he has the right to do that :P
And to make sure tgp can continue to use it, we forked it.

[greg-benner-klick-sensei]

@BenWiederhake I tried the fork with the same

error: dereferencing pointer to incomplete type 'RSA {aka struct rsa_st}'
   ret->e = unwrap_bn (TGLC_bn_new ());

in Ubuntu. Looks like an OpenSSL issue still.

[BenWiederhake]

The quoted line does not exist on the patched branch. Are you sure <ou tested branch "dev-1.4.0"? (Named after the telegram-purple version.)