Fix documentLoader variable name when passing to derive function #129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: PatStLouis <[email protected]>
BigBlueHat
approved these changes
Jan 27, 2025
davidlehn
reviewed
Jan 27, 2025
| return deriveCloned({ | ||
| verifiableCredential, | ||
| documentLoader: loader, | ||
| loader, |
Contributor
There was a problem hiding this comment.
It might make more sense to call the param documentLoader in these APIs. That's more invasive and would break callers, but it would make the param name align through the stack.
Collaborator
Author
There was a problem hiding this comment.
Agreed however this is from the jsigs library so would have to be tackled separately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix context issues we have been experiencing, the document loader class wasn't being passed properly and was getting overwritten.