Skip to content

Refactor create algorithm to address issues #3 and #4#7

Open
filip26 wants to merge 14 commits into
w3c-ccg:mainfrom
filip26:create-refactor-3
Open

Refactor create algorithm to address issues #3 and #4#7
filip26 wants to merge 14 commits into
w3c-ccg:mainfrom
filip26:create-refactor-3

Conversation

@filip26

@filip26 filip26 commented Mar 17, 2026

Copy link
Copy Markdown

This PR addresses issues #3 and #4. It allows passing a predefined DID document and an existing key pair to the algorithm, as well as defining a custom verification method ID. Feedback welcome.


Preview | Diff

@filip26
filip26 requested a review from msporny as a code owner March 17, 2026 18:47
@filip26
filip26 marked this pull request as draft March 17, 2026 19:33
@filip26

filip26 commented Mar 17, 2026

Copy link
Copy Markdown
Author

converting to draft; thinking about introducing didCelDocument term/var alongside the initial didDocument might help clarify the distinction.

@filip26
filip26 marked this pull request as ready for review March 18, 2026 17:36
Comment thread index.html Outdated
Comment thread index.html Outdated
Comment thread index.html Outdated
Comment thread index.html Outdated
Comment thread index.html Outdated
Comment thread index.html Outdated
filip26 and others added 5 commits April 10, 2026 16:32
Co-authored-by: Manu Sporny <msporny@digitalbazaar.com>
Co-authored-by: Manu Sporny <msporny@digitalbazaar.com>
Co-authored-by: Manu Sporny <msporny@digitalbazaar.com>
Co-authored-by: Manu Sporny <msporny@digitalbazaar.com>
Co-authored-by: Manu Sporny <msporny@digitalbazaar.com>
Comment thread index.html Outdated
Comment thread index.html Outdated
Comment thread index.html
Comment on lines +623 to +624
and |options|. The output is a [=map=] containing the completed `did:cel` |didDocument|,
the generated |verificationMethod|, and the initial |cryptographicEventLog|, or an error.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not clear what the other side of the "or" is. Is the output all three of the listed "and" items or one error? Or can you get one or two of the listed "and" items with one or two errors?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The meaning is intended to be: A map is returned OR an error is raised.

Thank you for the reviews!

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. I think this does the job. There are other possibilities which you or others may suggest.

Suggested change
and |options|. The output is a [=map=] containing the completed `did:cel` |didDocument|,
the generated |verificationMethod|, and the initial |cryptographicEventLog|, or an error.
and |options|. The output is either a [=map=] containing the completed `did:cel` |didDocument|,
the generated |verificationMethod|, and the initial |cryptographicEventLog| or an error.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The primary purpose is to explain what result to expect without forcing the reader to go through the algorithm. The possibility of an error is implicit, so we could omit “or an error” entirely.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the other major option. I'm OK with either; just need to separate the error from the stuff in the map.

Suggested change
and |options|. The output is a [=map=] containing the completed `did:cel` |didDocument|,
the generated |verificationMethod|, and the initial |cryptographicEventLog|, or an error.
and |options|. If not an error, the output is a [=map=] containing the completed `did:cel`
|didDocument|, the generated |verificationMethod|, and the initial |cryptographicEventLog|.

Comment thread index.html Outdated
Comment thread index.html Outdated
Comment thread index.html Outdated
Comment thread index.html Outdated
Comment thread index.html Outdated
Comment thread index.html Outdated
Comment thread index.html Outdated
Comment thread index.html Outdated
Comment thread index.html Outdated
Comment thread index.html Outdated
Comment thread index.html Outdated
filip26 and others added 3 commits April 13, 2026 18:18
Co-authored-by: Manu Sporny <msporny@digitalbazaar.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
@filip26

filip26 commented Apr 30, 2026

Copy link
Copy Markdown
Author

Something is still wrong with GitHub. After committing a review from @TallTed, the entire file was replaced, forcing me to revert to the previous commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants