Update 'array item' tests to set arrays for the tested properties#56
Open
jchartrand wants to merge 2 commits intow3c-ccg:mainfrom
Open
Update 'array item' tests to set arrays for the tested properties#56jchartrand wants to merge 2 commits intow3c-ccg:mainfrom
jchartrand wants to merge 2 commits intow3c-ccg:mainfrom
Conversation
change type and @context array item tests to send arrays
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the following two tests in 10-issuer.js:
'"credential.type" items MUST be strings'
and
'credential "@context" items MUST be strings.'
so that they now set arrays for the properties to be tested.
The two tests both appear to be intended to test cases where the given property ('type' and '@context') is set to an array containing items that aren't strings, but I think the items aren't actually added into an array before setting.
For example, one of the requests that is sent for the 'type' test looks like so:
whereas I think it was meant to be sent like so (which it now does with the committed fix):