Skip to content

Add ability to designate tests as "untestable"#1248

Merged
howard-e merged 6 commits into
masterfrom
gh-1352-test-blocked
Jun 9, 2025
Merged

Add ability to designate tests as "untestable"#1248
howard-e merged 6 commits into
masterfrom
gh-1352-test-blocked

Conversation

@jugglinmike

@jugglinmike jugglinmike commented May 28, 2025

Copy link
Copy Markdown
Contributor

@howard-e howard-e left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having reviewed how this works in the related w3c/aria-at-app#1405 PR, I'm comfortable with the functionality and the code looks good to me.

As I mentioned in my review there, just need to call out that the requested string needs to be updated:

  • Were there additional undesirable behaviors? -> Did negative side effects occur? (code)
  • No, there were no additional undesirable behaviors. -> No, negative side effects did not occur. (code)
  • Yes, there were additional undesirable behaviors. -> Yes, negative side effects occured. (code)
  • Undesirable behaviors -> Negative side effects (this appears when the above radio option is selected, and it wasn't listed in the linked issue but seems reasonable for that copy to be used here) (code)

@jugglinmike

Copy link
Copy Markdown
Contributor Author

Thanks for reviewing and for catching that, @howard-e! In addition to adding that critical change, I've removed the spuriously-generated files and merged in the master branch so CI won't generate them again.

1 similar comment
@jugglinmike

Copy link
Copy Markdown
Contributor Author

Thanks for reviewing and for catching that, @howard-e! In addition to adding that critical change, I've removed the spuriously-generated files and merged in the master branch so CI won't generate them again.

@howard-e howard-e left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me, thanks @jugglinmike !

@howard-e
howard-e merged commit ba42171 into master Jun 9, 2025
@howard-e
howard-e deleted the gh-1352-test-blocked branch June 9, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants