Test Plan for the Tabs with Automatic Activation Example#1255
Conversation
…g forwards and backwards to a `tab panel`
|
@mcking65 I made the requested changes. Please review them and let me know if I missed or misunderstood something. As for:
This has been fixed.
I verified this and the command is correct.
It works, except the window has to be maximized.
The default state for the first tab is I also caught an error in the assertion statement for the |
… in tests 'activateNextTabTabList' and 'activatePrevTabTabList'
…g by item for tests 'navForwardsToTabList' and 'navForwardsToTabListWhereATabIsNotSelected'
…abList' and 'reqInfoAboutNotSelectedTabTabList' except for when executing JAWS and NVDA insert+up commands
…IsNotSelected', change VO command to use two instead of 3 vo-left commands
…y of 2 when using arrow navigation in tests 'navForwardsToTabListWhereATabIsNotSelected' and 'navForwardsToTabList'
…qInfoAboutNotSelectedTabTabList'
…nd NVDA insert+up commands for tests 'reqInfoAboutTabTabList' and 'reqInfoAboutNotSelectedTabTabList'
…sing arrow navigation commands for assertions 'nameTabListDanishComposers' and 'roleTabList' in tests 'navBackToTabList' and 'navBackwardsToTabListWhereATabIsNotSelected'
|
I found several more issues that I overlooked in my first review and some new ones. I went ahead and pushed commits for them. Please review my commit statements. Here are a few I'd like to highlight. Virst, in the menu button test plans, we gained consensus between Vispero and Apple that that it is optional to convey the name and role of the menu when focus moves to an item inside the menu. We have the same type of condition when tabbing or using a quick nav key to move focus to a tab in the tablist. So, I changed the default priority of the following assertions to 3:
However, tablist has one key difference from a menu: you can browse across the tablist boundary with arrow keys. So, I pushed additional commits for arrow key navigation commands that overrides the default priority for these assertions with a value of 2. Note that the tablist name assertion was missing from the tests for requesting information; I pushed another commit to add it in, but not for insert+up, of course. Finally, I spent considerable time with VoiceOver in Safari and Chrome. There are definitely some strange bugs when setting focus on the tab panel container. When the tabpanel receives focus, frequently the VO cursor seems to be placed at the end of the tabpanel instead of the beginning. That is why it appears to require 3 instead of 2 vo-left commands. However, this is a bug. I believe the test should expect only 2 vo-left commands to be required.. I pushed a commit that changes the VO commands for navigating backward into the tablist to use only 2 vo-left commands. |
|
I think this is ready to ship |
|
Thank you @mcking65! |
Preview Tests
Preview Tabs with Automatic Activation Test Plan | For Pattern: tabs-automatic-activation
Preview all Tests
Resolves #454