Skip to content

Test Plan for the Tabs with Automatic Activation Example#1255

Merged
IsaDC merged 108 commits into
masterfrom
tests/tabs-automatic-v2
Jul 30, 2025
Merged

Test Plan for the Tabs with Automatic Activation Example#1255
IsaDC merged 108 commits into
masterfrom
tests/tabs-automatic-v2

Conversation

@IsaDC

@IsaDC IsaDC commented Jun 6, 2025

Copy link
Copy Markdown
Contributor

IsaDC and others added 30 commits June 5, 2025 14:08
@IsaDC

IsaDC commented Jul 29, 2025

Copy link
Copy Markdown
Contributor Author

@mcking65 I made the requested changes. Please review them and let me know if I missed or misunderstood something. As for:

Some special characters are not rendered correctly, example: convey name of the focused tab, 'Peter Müller'.

This has been fixed.

In Test 2: Navigate backwards into a tab list where a tab is not selected, I think the VO command VO+Left should probably only be pressed 2 times, not 3 ... however, I didn't verify this.

I verified this and the command is correct.

In Test 6: Request information about a not selected tab in a tab list, the setup script is not setting focus on the correct tab.

It works, except the window has to be maximized.

In Test 12: Navigate to the previous tab in a tab list, replace the assertion: convey state of the tab, 'not selected' with the assertion: convey state of the tab, 'selected'.

The default state for the first tab is selected, so I don't think that the assertion should be changed.

I also caught an error in the assertion statement for the tab panel text.

mcking65 added 17 commits July 29, 2025 16:49
… in tests 'activateNextTabTabList' and 'activatePrevTabTabList'
…g by item for tests 'navForwardsToTabList' and 'navForwardsToTabListWhereATabIsNotSelected'
…abList' and 'reqInfoAboutNotSelectedTabTabList' except for when executing JAWS and NVDA insert+up commands
…IsNotSelected', change VO command to use two instead of 3 vo-left commands
…y of 2 when using arrow navigation in tests 'navForwardsToTabListWhereATabIsNotSelected' and 'navForwardsToTabList'
…nd NVDA insert+up commands for tests 'reqInfoAboutTabTabList' and 'reqInfoAboutNotSelectedTabTabList'
…sing arrow navigation commands for assertions 'nameTabListDanishComposers' and 'roleTabList' in tests 'navBackToTabList' and 'navBackwardsToTabListWhereATabIsNotSelected'
@mcking65

Copy link
Copy Markdown
Contributor

@IsaDC

I found several more issues that I overlooked in my first review and some new ones. I went ahead and pushed commits for them. Please review my commit statements.

Here are a few I'd like to highlight.

Virst, in the menu button test plans, we gained consensus between Vispero and Apple that that it is optional to convey the name and role of the menu when focus moves to an item inside the menu. We have the same type of condition when tabbing or using a quick nav key to move focus to a tab in the tablist. So, I changed the default priority of the following assertions to 3:

Name of the tab list, 'Danish Composers', is conveyed
convey role 'tab list'

However, tablist has one key difference from a menu: you can browse across the tablist boundary with arrow keys. So, I pushed additional commits for arrow key navigation commands that overrides the default priority for these assertions with a value of 2.

Note that the tablist name assertion was missing from the tests for requesting information; I pushed another commit to add it in, but not for insert+up, of course.

Finally, I spent considerable time with VoiceOver in Safari and Chrome. There are definitely some strange bugs when setting focus on the tab panel container. When the tabpanel receives focus, frequently the VO cursor seems to be placed at the end of the tabpanel instead of the beginning. That is why it appears to require 3 instead of 2 vo-left commands. However, this is a bug. I believe the test should expect only 2 vo-left commands to be required.. I pushed a commit that changes the VO commands for navigating backward into the tablist to use only 2 vo-left commands.

@mcking65

Copy link
Copy Markdown
Contributor

I think this is ready to ship

@IsaDC

IsaDC commented Jul 30, 2025

Copy link
Copy Markdown
Contributor Author

Thank you @mcking65!
I'm going to merge the PR now.

@IsaDC
IsaDC marked this pull request as ready for review July 30, 2025 13:25
@IsaDC
IsaDC merged commit 1e6a5d0 into master Jul 30, 2025
9 checks passed
@IsaDC
IsaDC deleted the tests/tabs-automatic-v2 branch July 30, 2025 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create tests for APG design pattern example: Alert Dialog

3 participants