Skip to content

Refactor Test Plan for the Minimal Data Grid Example v2#1353

Merged
mcking65 merged 58 commits into
masterfrom
tests/minimal-data-grid-v2
May 21, 2026
Merged

Refactor Test Plan for the Minimal Data Grid Example v2#1353
mcking65 merged 58 commits into
masterfrom
tests/minimal-data-grid-v2

Conversation

@IsaDC

@IsaDC IsaDC commented Nov 26, 2025

Copy link
Copy Markdown
Contributor

@IsaDC
IsaDC requested a review from mcking65 November 26, 2025 04:24
@IsaDC

IsaDC commented Dec 14, 2025

Copy link
Copy Markdown
Contributor Author

@mcking65 Test plan ready for your review.

@IsaDC

IsaDC commented Dec 15, 2025

Copy link
Copy Markdown
Contributor Author

@mcking65 Test plan ready for your review 🙂

@mcking65

Copy link
Copy Markdown
Contributor

@IsaDC

I haven't yet reviewed the entire plan. Here are the observations I have for today.

The overall structure looks complete.

There are a few issues in the first 2 tests. In this grid, the column headers are not focusable. So, tabbing into the grid lands the cursor in a different place from arrowing. Tabbing focuses the first data cell in row 2 column 1. Arrowing lands on the column header for column 1 (date). So, we need some different content and position assertions for tab. You could set their default priority to 0 and then just add them as exceptions., similar to how we do the mode switching.

Also, for the 't' and 'shift+t' commands for JAWS in the first 2 test, we don't need a down arrow command. However, in the first tests, JAWS needs 2 down arrows instead of one when testing down arrow. Similarly, 2 up arrows are required in test 2.

The title of the first test has an extra word in it. It has "into to" instead of just "into".

@IsaDC

IsaDC commented Dec 18, 2025

Copy link
Copy Markdown
Contributor Author

@mcking65
I caught some VoiceOver commands that needed corrections in addition to the changes we discussed earlier.
Please review the test plan again, if possible, and let me know if I should set the priority to "May" for some of the navigation commands for JAWS and NVDA in virtual cursor and browse mode.

* Added row1 col1 position assertion to test 2 with 0 priority
* Changed assertion exceptions for shift+t so the assertions match 't' command from test 1. In both cases, the reading cursor goes to row 1/col 1.
Removed the words 'first' and 'last' from assertion text.
…ions for up arrow commands in test 2

In test 2, when navigating backward into a grid with arrow key commands, assert only the row number should be conveyed, make conveying column number optional.

For up arrow commands:

* remove assertion coordinatesCellColumn5Row7
* Add new assertion rowNumber7 with priority 2
* Add new assertion columnNumber5 with priority 3
* Also reduce priority to 3 for assertions for nameGrid and number of rows and number of columns.
mcking65 added 7 commits May 20, 2026 13:11
Replace cell coordinate assertions that combined rolw and col into a single assertion with separate assertions for row number and column number.
The assertion exceptions in the JAWS, NVDA, and VO commands specified priority 1 instead of priority 2 for some row and column number assertions.
Changed more assertion exceptions to reduce priority of row and col number assertions from 1 to 2.
…for navigating inside the grid

If navigating across a row, e.g., nav to next column, lower priority of the row number assertion to 3.

Conversely, if navigating up/down a column, reduce the priority of the column number assertion to 3.
The VoiceOver commands for next and previous column include the quick nav setting so removed the ctrl+opt+cmd modifiers.
For the left/right/up/down arrows, corrected the VO settings to be arrowQuickKeyNavOff instead of singleQuickKeyNavOff.
@mcking65
mcking65 merged commit 8e3f9d1 into master May 21, 2026
9 checks passed
@mcking65
mcking65 deleted the tests/minimal-data-grid-v2 branch May 21, 2026 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants