Move editorship to @npm #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well deserved! Great job @npm1 👍 |
|
Awesome, thank you for taking this on officially @npm1! |
|
You've got this, @npm1 ! |
timcappalli
approved these changes
Feb 28, 2024
|
Neat, thanks for all of the reviews! Merging! |
github-actions bot
added a commit
to mattdanielbrown/WebID
that referenced
this pull request
Feb 29, 2024
SHA: 42bebc1 Reason: push, by pull[bot] Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
npm1
pushed a commit
that referenced
this pull request
Jul 31, 2024
Co-authored-by: Sam Goto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As FedCM becomes more mature, this PR proposes that we start moving editorship of FedCM to @npm1 (and, ideally, a non-chrome co-editor, that we are actively looking for), to formalize an existing norm (@npm1 has been submitting more spec PR changes than myself for a considerable amount of time).
I'm still going to be around and help @npm1 through this transition, but I expect to fully transition at some point (say, by the end of the year?) out of editorship.
This PR signals that more concretely to set the expectations that @npm1 can (and should) be the primary reviewer of PRs going forward (and I can act as a secondary while @npm1 still ramps up).
Preview | Diff