Update HOWTO-chrome.md with button flow dev trial instruction #551
Conversation
Update HOWTO-chrome.md with button flow and use other account dev trial instruction
explorations/HOWTO-chrome.md
Outdated
| } | ||
| ``` | ||
|
|
||
| Note: IdP can add "widget" in "modes" to support this feature in the non-button flow. However, |
There was a problem hiding this comment.
But does it actually work? If not, then mention that it does not work
There was a problem hiding this comment.
It works. One can trigger the "use other account" row in the widget flow if they specify it in the config file.
There was a problem hiding this comment.
So it works with the chrome://flags but it won't work with the OT token? Does this mean we need a code change for this? We should probably not add this to the instructions if it is just missing in the code.
There was a problem hiding this comment.
IMO we don't need a code change for this. This instruction is for dev trialing the "Use Other Account" API so that we should keep the function. Agreed that we can remove this note.
Co-authored-by: Ted Thibodeau Jr <[email protected]>
|
PTAL. Thanks! |
explorations/HOWTO-chrome.md
Outdated
|
|
||
| ### Button Flow | ||
| The button flow differs from the widget flow in several ways. The most significant | ||
| difference is that the button flow is on the critical path of a user's sign-in |
explorations/HOWTO-chrome.md
Outdated
| } | ||
| ``` | ||
|
|
||
| Note: IdP can add "widget" in "modes" to support this feature in the non-button flow. However, |
There was a problem hiding this comment.
So it works with the chrome://flags but it won't work with the OT token? Does this mean we need a code change for this? We should probably not add this to the instructions if it is just missing in the code.
explorations/HOWTO-chrome.md
Outdated
| } | ||
| ``` | ||
|
|
||
| Note: IdP can add "widget" in "modes" to support this feature in the non-button flow. However, |
There was a problem hiding this comment.
IMO we don't need a code change for this. This instruction is for dev trialing the "Use Other Account" API so that we should keep the function. Agreed that we can remove this note.
explorations/HOWTO-chrome.md
Outdated
|
|
||
| ### Button Flow | ||
| The button flow differs from the widget flow in several ways. The most significant | ||
| difference is that the button flow is on the critical path of a user's sign-in |
SHA: 40e9897 Reason: push, by npm1 Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Update HOWTO-chrome.md with button flow dev trial instruction * Apply suggestions from code review Co-authored-by: Ted Thibodeau Jr <[email protected]> * Update HOWTO-chrome.md * Address comments --------- Co-authored-by: Ted Thibodeau Jr <[email protected]>
* Update HOWTO-chrome.md with button flow dev trial instruction * Apply suggestions from code review Co-authored-by: Ted Thibodeau Jr <[email protected]> * Update HOWTO-chrome.md * Address comments --------- Co-authored-by: Ted Thibodeau Jr <[email protected]>
No description provided.