Add sections for the continuation API bundle to the HOWTO #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelgoto
reviewed
May 8, 2024
explorations/HOWTO-chrome.md
Outdated
| }); | ||
| ``` | ||
| * These key/value pairs will be sent as-is in the ID assertion request: | ||
| `key=value&account_id=123&...` |
There was a problem hiding this comment.
Suggested change
| `key=value&account_id=123&...` | |
| `key=value&account_id=123&...` |
OTs are ok to be backwards incompatible, but if we could prefix these with param- we could avoid a backwards incompatibility problem later.
There was a problem hiding this comment.
the suggested change looks identical to the existing text to me?
Let me keep this as-is to match what is implemented. When we change the code I'll update this howto.
cbiesinger
commented
May 8, 2024
explorations/HOWTO-chrome.md
Outdated
| }); | ||
| ``` | ||
| * These key/value pairs will be sent as-is in the ID assertion request: | ||
| `key=value&account_id=123&...` |
There was a problem hiding this comment.
the suggested change looks identical to the existing text to me?
Let me keep this as-is to match what is implemented. When we change the code I'll update this howto.
samuelgoto
approved these changes
May 8, 2024
github-actions bot
added a commit
that referenced
this pull request
May 8, 2024
SHA: 82db3af Reason: push, by samuelgoto Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
to mattdanielbrown/WebID
that referenced
this pull request
May 9, 2024
) SHA: 82db3af Reason: push, by pull[bot] Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
npm1
pushed a commit
that referenced
this pull request
Jul 31, 2024
* Add sections for the continuation API bundle to the HOWTO * accept suggestions
npm1
pushed a commit
that referenced
this pull request
Sep 18, 2024
* Add sections for the continuation API bundle to the HOWTO * accept suggestions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not adding the scopes API yet because of the discussions around what it should look like.