Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add list of FPWD critical issues #623

Merged
merged 4 commits into from
Aug 14, 2024
Merged

Add list of FPWD critical issues #623

merged 4 commits into from
Aug 14, 2024

Conversation

wseltzer
Copy link
Collaborator

@wseltzer wseltzer commented Jul 16, 2024 •
edited by pr-preview bot
Loading

List the issues that, before publication of the FPWD, the WG and CG identified to be considered before CR publication.

Preview | Diff

@wseltzer
Add list of FPWD critical issues
2985eea 
List the issues that, cefore publication of the FPWD, the WG and CG identified to be considered before CR publication.
@wseltzer
Copy link
Collaborator Author

This list of issues: https://github.com/fedidcg/FedCM/issues?q=is%3Aissue+is%3Aopen+label%3AFPWD+sort%3Acreated-asc

@wseltzer wseltzer requested a review from npm1 July 16, 2024 18:15
samuelgoto
samuelgoto approved these changes Jul 16, 2024
View reviewed changes
Copy link
Collaborator

@samuelgoto samuelgoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

martinthomson
martinthomson reviewed Jul 20, 2024
View reviewed changes
martinthomson
martinthomson suggested changes Jul 21, 2024
View reviewed changes
Copy link
Contributor

@martinthomson martinthomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assert that "consideration" is too weak for this. These need resolutions that are backed by consensus.

@npm1 npm1 added the agenda+ Regular CG meeting agenda items label Jul 25, 2024
@wseltzer
Copy link
Collaborator Author

I assert that "consideration" is too weak for this. These need resolutions that are backed by consensus.

That's consistent with the W3C Process requirement that the group "MUST formally address all issues raised about the document since the previous maturity stage."

wseltzer and others added 2 commits July 29, 2024 08:43
@wseltzer @martinthomson
Update spec/index.bs
b8f88a8 
Accept MT's changes

Co-authored-by: Martin Thomson <[email protected]>
@wseltzer
Update index.bs per 30 July WG call
d49127a 
s/resolved/formally addressed/
@wseltzer
Copy link
Collaborator Author

wseltzer commented Jul 30, 2024 •
edited
Loading

On the 30 July WG call, it was suggested to adopt the language directly from the W3C Process, "formally addressed." PR updated accordingly.

@wseltzer wseltzer requested a review from martinthomson July 31, 2024 16:47
samuelgoto
samuelgoto reviewed Aug 6, 2024
View reviewed changes
spec/index.bs
<!-- ====================================================================== -->
# FPWD Issues # {#openissues}
<!-- ====================================================================== -->
Note: The WG has labeled the following issues as critical open issues that must be formally addressed before publication of a Candidate Recommendation.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still seeing issues in this label that isn't represented in this label, or in this PR.

Can I assume that these will eventually match up?

Copy link
Collaborator Author

@wseltzer wseltzer Aug 6, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Sam, #630 (now merged back into this PR) adds these issues to the list.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

wseltzer added a commit that referenced this pull request Aug 6, 2024
@wseltzer
Update index.bs
ba14476 
Additional issues added per #623 (review)
wseltzer added a commit that referenced this pull request Aug 6, 2024
@wseltzer
Add to issue list
9a3413f 
Additional issues per #623 (review)
@wseltzer wseltzer mentioned this pull request Aug 6, 2024
Merged
@wseltzer wseltzer requested a review from samuelgoto August 6, 2024 17:52
@wseltzer
Copy link
Collaborator Author

wseltzer commented Aug 6, 2024

Updated call for consensus until 13 August.

@bvandersloot-mozilla
Copy link
Collaborator

I assert that "consideration" is too weak for this. These need resolutions that are backed by consensus.

That's consistent with the W3C Process requirement that the group "MUST formally address all issues raised about the document since the previous maturity stage."

That works as well for Mozilla

@wseltzer wseltzer merged commit 22ec66d into main Aug 14, 2024
2 checks passed
@wseltzer wseltzer deleted the wseltzer-patch-1 branch August 14, 2024 15:42
github-actions bot added a commit that referenced this pull request Aug 14, 2024
@wseltzer @github-actions
Add list of FPWD critical issues (#623)
f00f585 
SHA: 22ec66d
Reason: push, by wseltzer

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
npm1 pushed a commit that referenced this pull request Sep 18, 2024
@wseltzer @martinthomson @npm1
Add list of FPWD critical issues (#623)
32a5c7a 
* Add list of FPWD critical issues

List the issues that, cefore publication of the FPWD, the WG and CG identified to be considered before CR publication.

* Update spec/index.bs

Accept MT's changes

Co-authored-by: Martin Thomson <[email protected]>

* Update index.bs per 30 July WG call

s/resolved/formally addressed/

* Add to issue list (#630)

Additional issues per #623 (review)

---------

Co-authored-by: Martin Thomson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelgoto samuelgoto samuelgoto approved these changes

@npm1 npm1 npm1 approved these changes

@martinthomson martinthomson Awaiting requested review from martinthomson

Assignees
No one assigned
Labels
agenda+ Regular CG meeting agenda items
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wseltzer @bvandersloot-mozilla @martinthomson @samuelgoto @npm1