Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add login_url in section 3.2 ("The config file") #710

Merged
merged 2 commits into from
Mar 31, 2025
Merged

Add login_url in section 3.2 ("The config file") #710

merged 2 commits into from
Mar 31, 2025

Conversation

cbiesinger
Copy link
Collaborator

@cbiesinger cbiesinger commented Mar 31, 2025 •
edited by pr-preview bot
Loading

@cbiesinger cbiesinger requested a review from npm1 March 31, 2025 15:30
npm1
npm1 reviewed Mar 31, 2025
View reviewed changes
Copy link
Collaborator

@npm1 npm1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add the other missing one, account_label?

@cbiesinger
Copy link
Collaborator Author

Can you also add the other missing one, account_label?

done, PTAL

@npm1
Copy link
Collaborator

npm1 commented Mar 31, 2025

Editorial change, so let's merge it now.

@npm1 npm1 merged commit c9b0418 into w3c-fedid:main Mar 31, 2025
1 of 2 checks passed
@cbiesinger cbiesinger deleted the loginurl branch March 31, 2025 15:55
github-actions bot added a commit that referenced this pull request Mar 31, 2025
@cbiesinger @github-actions
Add login_url in section 3.2 ("The config file") (#710)
feaab02 
SHA: c9b0418
Reason: push, by npm1

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit to mattdanielbrown/WebID that referenced this pull request Mar 31, 2025
@cbiesinger @github-actions
Add login_url in section 3.2 ("The config file") (w3c-fedid#710)
085e29b 
SHA: c9b0418
Reason: push, by pull[bot]

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@npm1 npm1 npm1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cbiesinger @npm1