Fallback to Cred Man when the API is not supported #395

marcoscaceres · 2025-10-30T06:35:55Z

There are platforms where the API is available, but it's not supported. For example, the API is available on older versions of an OS using modern browser (e.g., pre-macOS 26 running a new Safari), but credentials requests are currently not supported on that platform.

Closes #393
Closes #359

The following tasks have been completed:

~~[ ] Modified Web platform tests (link)~~ Not testable.

Implementation commitment:

WebKit - PR
Chromium (link to issue)
Gecko (link to issue)

Documentation and checks

Preview | Diff

index.html

mohamedamir · 2025-12-17T15:30:25Z

@marcoscaceres
Why not handling this via the allowed protocols?
i.e. always returning false on those platforms.

timcappalli · 2025-12-17T20:52:41Z

@marcoscaceres Why not handling this via the allowed protocols? i.e. always returning false on those platforms.

Allowed protocols would be how a developer would detect what can be used up front, but if a developer still makes a call and one of the methods isn't supported (e.g. supports get but not create), then the API needs to return with an appropriate error.

timcappalli

LGTM

marcoscaceres · 2025-12-18T07:52:54Z

Discussed with @mohamedamir ... we concluded that it would be good to just conditionally statically compile out the code when the API is not supported... in WebKit

#if HAVE(DIGITAL_CREDENTIALS_UI)
    if (options.digital) {
      DigitalCredential::discoverFromExternalSource(*document(), WTFMove(promise), WTFMove(options));
      return;
    }
#endif

Rationale being to keep compatibility with older browser engine versions by having them behave the same when an UI can't be presented.

We should say something in the spec though... I'll try to come up with something.

RByers · 2025-12-18T13:59:43Z

Agreed, thank you! FWIW this aligns with our general approach in Chrome for OSes which can't support an API - we want it to look the same to web developers as cases of a browser not supporting the API (fewer cases to worry about).

For DiscoverFromExternalSource(), adds a check to see if the digital credentials UI is available before attempting doing any processing. If there's no platform support, behave as if the API is not implemented by falling back to Credential Management API's default algorithms.

rdar://167807196 https://bugs.webkit.org/show_bug.cgi?id=305158 Reviewed by NOBODY (OOPS!). We now check whether digital credentials UI is available at the platform level before attempting to process any digital credentials related requests. This provides better developer ergonomics by allowing the API to behave the same way as it does on legacy platforms that don't support the API. Related spec change: w3c-fedid/digital-credentials#395 Relies on existing tests. * Source/WebCore/Modules/credentialmanagement/CredentialsContainer.cpp: (WebCore::CredentialsContainer::get): * Source/WebCore/Modules/identity/CredentialRequestCoordinator.cpp: (WebCore::CredentialRequestCoordinator::presentPicker): * Source/WebCore/Modules/identity/CredentialRequestCoordinator.h: * Source/WebCore/Modules/identity/DigitalCredential.cpp: (WebCore::DigitalCredential::discoverFromExternalSource):

marcoscaceres · 2026-01-09T02:13:35Z

@mohamedamir, @RByers, just confirming again this is Chrome's behavior (assuming from the above, it is)... I've sent a patch to WebKit to match WebKit/WebKit#56303. Please take another look at the updated spec text.

rdar://167807196 https://bugs.webkit.org/show_bug.cgi?id=305158 Reviewed by NOBODY (OOPS!). We now check whether digital credentials UI is available at the platform level before attempting to process any digital credentials related requests. This provides better developer ergonomics by allowing the API to behave the same way as it does on legacy platforms that don't support the API. Related spec change: w3c-fedid/digital-credentials#395 Relies on existing tests. * Source/WebCore/Modules/credentialmanagement/CredentialsContainer.cpp: (WebCore::CredentialsContainer::get): * Source/WebCore/Modules/identity/CredentialRequestCoordinator.cpp: (WebCore::CredentialRequestCoordinator::presentPicker): * Source/WebCore/Modules/identity/CredentialRequestCoordinator.h: * Source/WebCore/Modules/identity/DigitalCredential.cpp: (WebCore::DigitalCredential::discoverFromExternalSource):

index.html

Co-authored-by: Ted Thibodeau Jr <[email protected]>

mohamedamir

LGTM

Thank you!

rdar://167807196 https://bugs.webkit.org/show_bug.cgi?id=305158 Reviewed by NOBODY (OOPS!). We now check whether digital credentials UI is available at the platform level before attempting to process any digital credentials related requests. This provides better developer ergonomics by allowing the API to behave the same way as it does on legacy platforms that don't support the API. Related spec change: w3c-fedid/digital-credentials#395 Relies on existing tests. * Source/WebCore/Modules/credentialmanagement/CredentialsContainer.cpp: (WebCore::CredentialsContainer::get): * Source/WebCore/Modules/identity/CredentialRequestCoordinator.cpp: (WebCore::CredentialRequestCoordinator::presentPicker): * Source/WebCore/Modules/identity/CredentialRequestCoordinator.h: * Source/WebCore/Modules/identity/DigitalCredential.cpp: (WebCore::DigitalCredential::discoverFromExternalSource): * Source/WebCore/page/Page.cpp: * Source/WebCore/page/Page.h: (WebCore::Page::authenticatorCoordinator):

SHA: b4aa7b0 Reason: push, by marcoscaceres Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

rdar://167807196 https://bugs.webkit.org/show_bug.cgi?id=305158 Reviewed by NOBODY (OOPS!). We now check whether digital credentials UI is available at the platform level before attempting to process any digital credentials related requests. This provides better developer ergonomics by allowing the API to behave the same way as it does on legacy platforms that don't support the API. Related spec change: w3c-fedid/digital-credentials#395 Relies on existing tests. * Source/WebCore/Modules/credentialmanagement/CredentialsContainer.cpp: (WebCore::CredentialsContainer::get): * Source/WebCore/Modules/identity/CredentialRequestCoordinator.cpp: (WebCore::CredentialRequestCoordinator::presentPicker): * Source/WebCore/Modules/identity/CredentialRequestCoordinator.h: * Source/WebCore/Modules/identity/DigitalCredential.cpp: (WebCore::DigitalCredential::discoverFromExternalSource): * Source/WebCore/loader/EmptyClients.cpp: (WebCore::pageConfigurationWithEmptyClients): * Source/WebCore/page/Chrome.cpp: * Source/WebCore/page/Chrome.h: * Source/WebCore/page/ChromeClient.cpp: * Source/WebCore/page/ChromeClient.h: * Source/WebCore/page/Page.cpp: * Source/WebCore/page/Page.h: (WebCore::Page::authenticatorCoordinator): * Source/WebCore/page/PageConfiguration.cpp: (WebCore::PageConfiguration::PageConfiguration): * Source/WebCore/page/PageConfiguration.h: * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: * Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm: * Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h: * Source/WebKit/UIProcess/DigitalCredentials/WKDigitalCredentialsPicker.h: * Source/WebKit/UIProcess/DigitalCredentials/WKDigitalCredentialsPicker.mm: * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::showDigitalCredentialsPicker): (WebKit::WebPageProxy::fetchRawDigitalCredentialRequests): (WebKit::WebPageProxy::dismissDigitalCredentialsPicker): * Source/WebKit/UIProcess/WebPageProxy.messages.in: * Source/WebKit/UIProcess/ios/PageClientImplIOS.h: * Source/WebKit/UIProcess/ios/PageClientImplIOS.mm: * Source/WebKit/UIProcess/ios/WKContentViewInteraction.h: * Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm: * Source/WebKit/UIProcess/mac/PageClientImplMac.h: * Source/WebKit/UIProcess/mac/PageClientImplMac.mm: * Source/WebKit/UIProcess/mac/WebViewImpl.h: * Source/WebKit/UIProcess/mac/WebViewImpl.mm: * Source/WebKit/WebKitSwift/WebKitSwift.h: * Source/WebKit/WebProcess/DigitalCredentials/DigitalCredentialsCoordinator.cpp: * Source/WebKit/WebProcess/DigitalCredentials/DigitalCredentialsCoordinator.h: * Source/WebKit/WebProcess/DigitalCredentials/DigitalCredentialsCoordinator.messages.in: * Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp: * Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h: * Source/WebKit/WebProcess/WebPage/WebPage.cpp: (WebKit::m_toolbarsAreVisible): * Source/WebKit/WebProcess/WebPage/WebPage.h: * Source/WebKitLegacy/mac/WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):

rdar://167807196 https://bugs.webkit.org/show_bug.cgi?id=305158 Reviewed by NOBODY (OOPS!). We now check whether digital credentials UI is available at the platform level before attempting to process any digital credentials related requests. This provides better developer ergonomics by allowing the API to behave the same way as it does on legacy platforms that don't support the API. Related spec change: w3c-fedid/digital-credentials#395 Relies on existing tests. * Source/WebCore/Modules/credentialmanagement/CredentialsContainer.cpp: (WebCore::CredentialsContainer::get): * Source/WebCore/Modules/identity/CredentialRequestCoordinator.cpp: (WebCore::CredentialRequestCoordinator::presentPicker): * Source/WebCore/Modules/identity/CredentialRequestCoordinator.h: * Source/WebCore/Modules/identity/DigitalCredential.cpp: (WebCore::DigitalCredential::discoverFromExternalSource): * Source/WebCore/loader/EmptyClients.cpp: (WebCore::pageConfigurationWithEmptyClients): * Source/WebCore/page/Chrome.cpp: * Source/WebCore/page/Chrome.h: * Source/WebCore/page/ChromeClient.cpp: * Source/WebCore/page/ChromeClient.h: * Source/WebCore/page/Page.cpp: * Source/WebCore/page/Page.h: (WebCore::Page::authenticatorCoordinator): * Source/WebCore/page/PageConfiguration.cpp: (WebCore::PageConfiguration::PageConfiguration): * Source/WebCore/page/PageConfiguration.h: * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: * Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm: * Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h: * Source/WebKit/UIProcess/DigitalCredentials/WKDigitalCredentialsPicker.h: * Source/WebKit/UIProcess/DigitalCredentials/WKDigitalCredentialsPicker.mm: * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::showDigitalCredentialsPicker): (WebKit::WebPageProxy::fetchRawDigitalCredentialRequests): (WebKit::WebPageProxy::dismissDigitalCredentialsPicker): * Source/WebKit/UIProcess/WebPageProxy.messages.in: * Source/WebKit/UIProcess/ios/PageClientImplIOS.h: * Source/WebKit/UIProcess/ios/PageClientImplIOS.mm: * Source/WebKit/UIProcess/ios/WKContentViewInteraction.h: * Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm: * Source/WebKit/UIProcess/mac/PageClientImplMac.h: * Source/WebKit/UIProcess/mac/PageClientImplMac.mm: * Source/WebKit/UIProcess/mac/WebViewImpl.h: * Source/WebKit/UIProcess/mac/WebViewImpl.mm: * Source/WebKit/WebKitSwift/IdentityDocumentServices/WKIdentityDocumentPresentmentController.h: * Source/WebKit/WebKitSwift/IdentityDocumentServices/WKIdentityDocumentPresentmentDelegate.h: * Source/WebKit/WebKitSwift/IdentityDocumentServices/WKIdentityDocumentPresentmentError.h: * Source/WebKit/WebKitSwift/IdentityDocumentServices/WKIdentityDocumentPresentmentMobileDocumentRequest.h: * Source/WebKit/WebKitSwift/IdentityDocumentServices/WKIdentityDocumentPresentmentRawRequest.h: * Source/WebKit/WebKitSwift/IdentityDocumentServices/WKIdentityDocumentPresentmentRequest.h: * Source/WebKit/WebKitSwift/IdentityDocumentServices/WKIdentityDocumentPresentmentResponse.h: * Source/WebKit/WebKitSwift/IdentityDocumentServices/WKIdentityDocumentRawRequestValidator.h: * Source/WebKit/WebKitSwift/WebKitSwift.h: * Source/WebKit/WebProcess/DigitalCredentials/DigitalCredentialsCoordinator.cpp: * Source/WebKit/WebProcess/DigitalCredentials/DigitalCredentialsCoordinator.h: * Source/WebKit/WebProcess/DigitalCredentials/DigitalCredentialsCoordinator.messages.in: * Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp: * Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h: * Source/WebKit/WebProcess/WebPage/WebPage.cpp: (WebKit::m_toolbarsAreVisible): * Source/WebKit/WebProcess/WebPage/WebPage.h: * Source/WebKitLegacy/mac/WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):

marcoscaceres commented Oct 30, 2025

View reviewed changes

index.html Outdated Show resolved Hide resolved

marcoscaceres commented Oct 30, 2025

View reviewed changes

index.html Outdated Show resolved Hide resolved

marcoscaceres marked this pull request as ready for review December 17, 2025 01:58

marcoscaceres requested a review from a team as a code owner December 17, 2025 01:58

marcoscaceres requested a review from mohamedamir December 17, 2025 02:00

marcoscaceres mentioned this pull request Dec 17, 2025

Add error for when the API is supported, but the platform doesn't support it #359

Closed

timcappalli approved these changes Dec 17, 2025

View reviewed changes

Fix create call support check

d3740bb

marcoscaceres force-pushed the create_fixup branch from d31c8b8 to 22b2373 Compare January 9, 2026 01:09

marcoscaceres force-pushed the create_fixup branch from f5164be to b751bc3 Compare January 9, 2026 02:06

marcoscaceres changed the title ~~Fix create call support check~~ Fallback to Cred Man when the API is not supported Jan 9, 2026

marcoscaceres requested a review from RByers January 9, 2026 02:09

marcoscaceres mentioned this pull request Jan 9, 2026

Digital credentials: don't do any processing if there's no UI available WebKit/WebKit#56303

Open

marcoscaceres requested a review from timcappalli January 9, 2026 02:14

TallTed reviewed Jan 12, 2026

View reviewed changes

index.html Outdated Show resolved Hide resolved

TallTed reviewed Jan 12, 2026

View reviewed changes

index.html Outdated Show resolved Hide resolved

TallTed reviewed Jan 12, 2026

View reviewed changes

index.html Outdated Show resolved Hide resolved

marcoscaceres and others added 2 commits January 13, 2026 12:07

Update index.html

4175f64

Co-authored-by: Ted Thibodeau Jr <[email protected]>

Apply suggestions from code review

afa6306

Co-authored-by: Ted Thibodeau Jr <[email protected]>

mohamedamir approved these changes Jan 13, 2026

View reviewed changes

Merge branch 'main' into create_fixup

3b45e75

timcappalli approved these changes Jan 13, 2026

View reviewed changes

Merge branch 'main' into create_fixup

2051e3c

marcoscaceres merged commit b4aa7b0 into main Jan 13, 2026
3 checks passed

marcoscaceres deleted the create_fixup branch January 13, 2026 18:26

github-actions bot added a commit that referenced this pull request Jan 13, 2026

Fallback to Cred Man when the API is not supported (#395)

acbdbbd

SHA: b4aa7b0 Reason: push, by marcoscaceres Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fallback to Cred Man when the API is not supported #395

Fallback to Cred Man when the API is not supported #395

Uh oh!

marcoscaceres commented Oct 30, 2025 •

edited by pr-preview bot

Loading

Uh oh!

Uh oh!

Uh oh!

mohamedamir commented Dec 17, 2025

Uh oh!

timcappalli commented Dec 17, 2025

Uh oh!

timcappalli left a comment

Uh oh!

marcoscaceres commented Dec 18, 2025 •

edited

Loading

Uh oh!

RByers commented Dec 18, 2025

Uh oh!

marcoscaceres commented Jan 9, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mohamedamir left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Fallback to Cred Man when the API is not supported #395

Fallback to Cred Man when the API is not supported #395

Uh oh!

Conversation

marcoscaceres commented Oct 30, 2025 • edited by pr-preview bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mohamedamir commented Dec 17, 2025

Uh oh!

timcappalli commented Dec 17, 2025

Uh oh!

timcappalli left a comment

Choose a reason for hiding this comment

Uh oh!

marcoscaceres commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RByers commented Dec 18, 2025

Uh oh!

marcoscaceres commented Jan 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mohamedamir left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

marcoscaceres commented Oct 30, 2025 •

edited by pr-preview bot

Loading

marcoscaceres commented Dec 18, 2025 •

edited

Loading

marcoscaceres commented Jan 9, 2026 •

edited

Loading