fix: allow add test plans disclosure to add test plan versions without initial reports #1649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howard-e
approved these changes
Nov 17, 2025
Contributor
howard-e
left a comment
howard-e
left a comment
There was a problem hiding this comment.
Looks good, thanks!
This issue is quite old but likely wasn't discovered until now due to another method for adding initial reports being used.
Makes sense, I remember this dropdown being dictated by the test plans. There's defaulting logic to show "Versions in R&D or Deprecated" when a test plan was selected with no viable versions, at least on an older version of Data Management.
This dropdown is now dictated by the test plan versions. Both ways are fine but I could see how the reports.length logic got conflated in putting that altogether. It certainly needed a central entry point from earlier. Well done!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue was discovered by @ChrisC while manual testing. The dropdown in
AddTestPlansis populated with test plans that have at least one version inDRAFT,CANDIDATE, orRECOMMENDED. It also filters for test plans that have a version in one of those phases with an existing report. This secondary filter is incorrect.This issue is quite old but likely wasn't discovered until now due to another method for adding initial reports being used.