Skip to content

Conversation

@howard-e
Copy link
Contributor

@howard-e howard-e commented Nov 18, 2025

Address #1652

This PR addresses 2 notable issues which affected older submitted reports but were part of advanced test plan versions:

  1. Assertions marked as 'untestable' weren't in sync with another tester's run that marked it as 'failed'. This wasn't a problem before but now that conflicts consider these cases of untestable vs failed since fix: Show untestable vs passing/failing assertions as conflicts #1599, it has to
  2. Now that AtBugs and encodedId exists on a negative side effect since feat: AtBugs for tracking known AT issues #1577, those also have to be explicitly ignored or even when the negative side effect matches, it shows up as a conflict

Apart from those, found that a created negative side effect could not be removed or updated for a Test Run page.

For reviewers:
To confirm the changes of the migration, locally I removed the markedFinalAt attribute for those TestPlanReport rows so I could easily view them in the Test Queue

@howard-e howard-e changed the title fix: Phase update to RECOMMENDED and restore negative side effects expected mutations fix: Restore phase update to RECOMMENDED and restore negative side effects expected mutations Nov 18, 2025
@howard-e howard-e requested a review from stalgiag November 18, 2025 22:09
Copy link
Contributor

@stalgiag stalgiag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! This is an important catch. Thanks for thinking it through and especially for being thorough in capturing the neg side effect copying edge behaviors here

@stalgiag stalgiag merged commit 6af6983 into development Nov 18, 2025
1 check passed
@stalgiag stalgiag deleted the fix-phase-update branch November 18, 2025 22:27
howard-e added a commit that referenced this pull request Dec 11, 2025
Create December 11, 2025 Release

Includes the following changes:
* #1582, which addresses #1572
* #1592
* #1619 
* #1621
* #1640, which addresses #1083
* #1642
* #1643
* #1641
* #1639, which addresses #1539
* #1644
* #1649
* #1647
* #1653, which addresses #1652
* #1654 
* #1656
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants