Add Practice Page for Supporting Color Contrast Settings#2991
Add Practice Page for Supporting Color Contrast Settings#2991mcking65 wants to merge 259 commits into
Conversation
|
@mcking65 |
|
The ARIA Authoring Practices (APG) Task Force just discussed The full IRC log of that discussion<Jem> Topic:New high contrast practice page<Jem> github:PR 2991 - Add Practice Page for Supporting High Contrast <dmontalvo> s/:New/: New/ <Jem> github:https://github.com//pull/2991 <dmontalvo> Matt_King: Big thanks to jongund, this is great <dmontalvo> ... In the PR there is a link to the preview <Jem> https://deploy-preview-315--aria-practices.netlify.app/aria/apg/practices/high-contrast/ <dmontalvo> ... At this point in the drafting process we have very good and useful info. Now I am thinking that we probably want to focus a bit on information architecture <dmontalvo> ... Think about our audience will learn from this page, we have different audiences <dmontalvo> ... We have not covered testing techniques here yet <dmontalvo> ... We had said if there is already a resource in the WAI website we could use <dmontalvo> Daniel: Maybe Easy Checks, not clear on specific <dmontalvo> Matt_King: Can we open an issue to that and then link from our pages? <dmontalvo> Daniel: We could, that's under EO <dmontalvo> Matt_King: We can start drafting it here, then open an issue to Easy Checks, and based on traction we could eventually remove it from here <dmontalvo> jongund: I could do that <dmontalvo> Matt_King: It seems to me there is something really valuable that you learned from James. I don't think EO would have included this information, they have more general contrast testing tools <dmontalvo> ... I documented how to test this color contrast issues <dmontalvo> Matt_King: Probably it's on our own wiki under accessibility testing <Jem> https://github.com/w3c/aria-practices/wiki/Pull-Request-Review-Process <dmontalvo> Daniel: Probably that's out of scope for Easy Checks, we'd have to include this ourselves <dmontalvo> CurtBellew: Are we saying this is too complicated? <dmontalvo> Matt_King: No, just out of sccope for the Easy Checks project <dmontalvo> jongund: It's not that complicated to put Windows or Linux in high contrast mode <siri> q+ <dmontalvo> Matt_King: Under operating system, high contrast features, do you know if we could provide links to the Microsoft, Apple, and Google documentation about those features? <dmontalvo> Jem: Wouldn't it be changing? <dmontalvo> Matt_King: I'd hope they have stable information about accessibility features <Jem> https://support.microsoft.com/en-us/windows/change-color-contrast-in-windows-fedc744c-90ac-69df-aed5-c8a90125e696#:~:text=Select%20the%20Start%20button%2C%20and,colors%20on%20the%20screen%20change. <dmontalvo> Matt_King: Our current info is not very useful. Without any documentation to help people turn it on and off, I don't think it's actionable information <dmontalvo> ... One solution to that is for us to provide a link to their documentation about the feature <dmontalvo> jongund: Probably these days the accessibility links are more stable than they were <dmontalvo> Matt_King: Also if a link breaks, our link checker will ick it up <dmontalvo> Jem: Good idea <dmontalvo> jongund: I don't have a recent Android device <dmontalvo> Matt_King: Anybody in this group can find the appropriate info <dmontalvo> Matt_King: Also, where we are talking about the use of specific CSS properties, it would be great to link to the spec <dmontalvo> s/to the spec/directly to the spec or to MDN/ <dmontalvo> Matt_King: I am going to spend a bit on time on this PR, to focus on what using these things does, for people to understtand the "Why" <dmontalvo> jongund: Do you think the screenshots are useful? <dmontalvo> Matt_King: Love the idea of making things more visual, I can't comment on those though <Jem> System Colors <Jem> "The following table identifies the current system colors defined in CSS Color Module Level 4. System colors are supported in all major browsers, but the actual colors they render may vary between browsers and operating systems based on default and user theme and contrast settings." <dmontalvo> jongund: What about the table on the system colors section that explain how browsers deal with ach of the colors <dmontalvo> ... In Windows, it changes the colors used by the OS, i mac it just filters them out and transforms the bitmap <dmontalvo> ... If you are taking a screenshot on the mac you are getting that without high contrast <dmontalvo> Matt_King: That is actionable information <dmontalvo> ... For sccreen reader users the sample column is blank. I understand it's just a color in there <dmontalvo> ... Should be try to put something in there? <dmontalvo> Matt_King: Should we put an ARIA label on the td? <dmontalvo> jongund: Sample accent color <dmontalvo> Matt_King: I think it'd be cool to have the name of the color <dmontalvo> jongund: The actual color varies depending on the setting <dmontalvo> Jem: But you have the hex code <dmontalvo> Matt_King: We don't want hex code in the label, just the name that corresponds to it <dmontalvo> Jem: I think it's possible <dmontalvo> rrsagent, draft minutes <RRSAgent> I have made the request to generate https://www.w3.org/2024/06/04-aria-apg-minutes.html dmontalvo <dmontalvo> Meeting: ARIA APG Teleconference <dmontalvo> Chair: Mat <dmontalvo> rrsagent, draft minutes <RRSAgent> I have made the request to generate https://www.w3.org/2024/06/04-aria-apg-minutes.html dmontalvo <dmontalvo> zakim, bye <Zakim> leaving. As of this point the attendees have been CurtBellew, curt_bellew, Arie <dmontalvo> rrsagent, bye <RRSAgent> I'm staying, dmontalvo; no access has been specified for the meeting record <Jem> rrsagent, make minutes <RRSAgent> I have made the request to generate https://www.w3.org/2024/06/04-aria-apg-minutes.html Jem <Jem> regret+ Mike <Jem> rrsagent, make minutes <RRSAgent> I have made the request to generate https://www.w3.org/2024/06/04-aria-apg-minutes.html Jem <Jem> MEETING: ARIA APG |
Merge branch 'main' into high-contrast-practice
|
@mcking65 |
|
The ARIA Authoring Practices (APG) Task Force just discussed this issue. The full log of that discussionMatt_King: This is a giant pull request, and it’s been open for a long time. I recently merged the “main” branch back into it to make sure there are no conflict |
joelamyman
left a comment
There was a problem hiding this comment.
I think I put myself forward to have a read through this and provide any feedback, although I can't see that in the minutes, so please feel free to dismiss this feedback if I've got this issue confused with another 😅
This is a really great piece and does such a great job at consolidating these different colour-related settings, and providing guidance around how they work, how to develop for them, and how to test them. I think this is a fantastic resource, and would be great for people trying to understand the topic.
I've left a few minor points of feedback, but one other thing I wanted to mention is around the structure of the document. It seems like it might have changed a few times with content moving around a little bit, and is ever so slightly inconsistent.
When we looked at the page during the previous APG task force call, I thought it could do with information about authoring practices for each colour setting, however, after reviewing the page I now see that this is not needed as every section has this.
To help make the structure more clear, I wonder if each section could be separated in to:
<h2><Name of the setting></h2>
<h3><Name of the setting> Example</h3>
<h3>Supporting <Name of the setting></h3>
<h3>Testing <Name of the setting></h3>
I note that most sections follow this, but having it consistent would make this really clear.
For the suggested “Supporting…” heading, I don't think this needs additional content, but my suggestion is more to move any applicable content from each setting’s intro paragraph, and put it under a dedicated heading to make it easy to find, given how important it is.
To this effect, I also wondered if the “SVG graphics” section and “Testing for Contrast Theme Support” headings, could fall under the “Contrast Themes” h2 to also help improve the structure.
| browsers set the <code>forced-colors</code> property to <code>active</code>. | ||
| When using ARIA to alter the semantics of elements authors need to verify the appropriate system color for each feature when forced colors are enabled. | ||
|
|
||
| The following table provides guidance on how system colors should be applied when forced colors is enabled for common user interface controls. When elements with altered semantics do not match the appropriate system color for elements, authors must set the appropriate system color using the <code>forced-colors: active</code> media query. |
There was a problem hiding this comment.
I checked this a few times, and I wonder if this line is relating to the "Browser System Color Support" table later on in the page. Maybe it's been moved since this content was first written, as the next table after this text relates to the switch example. Therefore, I wondered if we wanted to add a link in this text, to allow people to jump to the "Browser System Color Support" table.
There was a problem hiding this comment.
If you were looking in the pull request you won't see it, it is a generated table that is visible in preview mode.
| Most interactive custom components should be using the <code>buttonBorder</code>, <code>ButtonFace</code> and <code>ButtonText</code> values. | ||
| </li> | ||
| <li> | ||
| For more complex interactive components to differentiate component features consider using <code>Highlight</code> or <code>ActiveText</code> values to make the features easier to identify. See the <a href="#html-input-range-contrast-theme">HTML range slider</a> (e.g. <code>input[type="range"])</code>) for how other colors than just button colors are used in styling the slider and thumb features. |
There was a problem hiding this comment.
The “HTML range slider” link doesn’t seem to redirect anywhere. I wasn’t sure where this should point to, or whether this content needs removing?
There was a problem hiding this comment.
I have removed this section, I do not think we should do to much about using media queries for custom colors, do many bugs.
|
@joelamyman really like your suggestion for the structure of the content. |
|
The ARIA Authoring Practices (APG) Task Force just discussed The full IRC log of that discussion<jugglinmike> subtopic: PR 2991: Add Practice Page for Supporting Color Contrast Settings by mcking65<jugglinmike> github: https://github.com//pull/2991 <jugglinmike> Matt_King: jongund_ do you want to implement this feedback, or should I? <jugglinmike> jongund_: I can take care of it <jugglinmike> Matt_King: Thank you! I think most of this feedback is pretty straightfoward <jugglinmike> Matt_King: One part concerns the whole structure. Thanks to JoeLamyman for bringing a holistic perspective <jugglinmike> Matt_King: That is a clear and well-thought-out suggestion, so I think it's worth incorporating |
…s into high-contrast-practice
|
The ARIA Authoring Practices (APG) Task Force just discussed The full IRC log of that discussion<jugglinmike> subtopic: PR 2991: Add Practice Page for Supporting Color Contrast Settings by mcking65<jugglinmike> github: https://github.com//pull/2991 <jugglinmike> Matt_King: We had a review from Joe, who suggested some changes <jugglinmike> Matt_King: And this morning, jongund pushed a commit <jugglinmike> jongund: Yeah, I've been re-organizing the heading structure based on those suggestions <jugglinmike> jongund: I'm going to work on updating some of the content, too. We've been missing a section for testing <jugglinmike> jongund: So this is in-progress <jugglinmike> jongund: I'll send an e-mail to the list when this is ready <jugglinmike> Matt_King: Sounds like good progress! Thank you! |
|
Discussed in 29 April meeting |
|
The ARIA Authoring Practices (APG) Task Force just discussed The full IRC log of that discussion<jugglinmike> Subtopic: PR 2991: Add Practice Page for Supporting Color Contrast Settings by mcking65<jugglinmike> github: https://github.com//pull/2991 <jugglinmike> Matt_King: Here, jongund has made updates, so it's ready for the next round of review <jugglinmike> jongund: Yeah, I'm caught up on all the feedback I've received to date <jugglinmike> Matt_King: We're looking for feedback from a few people <jugglinmike> Matt_King: The person who last requested changes was Adam <jugglinmike> Matt_King: jongund, if you've responded to those changes, then I think I should re-request review from Adam. I've done that just now <jugglinmike> Matt_King: We haven't had participation from Sarah in a while. I wonder if she could look again because she had a lot of input before... <jugglinmike> Matt_King: It would be great if we could get Sarah's input on the current state <jugglinmike> Matt_King: howard-e is also on the list of reviewers <jugglinmike> Matt_King: CurtBellew and JoeLamyman, both of your names are on here. Are you able to do those reviews? <jugglinmike> JoeLamyman: Yes <jugglinmike> CurtBellew: Yes <jugglinmike> Matt_King: I think all of your feedback has been incorporated, JoeLamyman <jugglinmike> JoeLamyman: Awesome, thank you <jugglinmike> Matt_King: It seems like I should reach out to people directly and find out if they are available (and remove them from the "reviewers" list if they are not) |
Part of the resolution of issue #2864.
Preview Links
WAI Preview Link (Last built on Mon, 20 Apr 2026 01:29:27 GMT).