-
Notifications
You must be signed in to change notification settings - Fork 131
[html-aam PR 510] switch attribute for checkbox inputs #2217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
closes #496 if this feature goes through.
This one was very messy. @scottaohara if you have the time, please take a closer look to make sure I didn't mess anything up. |
Re-adding reviewer @cookiecrook. @annevk should also be a reviewer but unable to add him at the moment (unsure why), investigating. |
We can only assign folks who are in the ARIA contributors group. @annevk can still review but we can't assign him. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing most platform mappings... Should this be marked as a draft PR?
</td> | ||
</tr> | ||
<tr> | ||
<th><a href="https://developer.apple.com/reference/appkit/nsaccessibility">AX</a></th> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The full name is the "The macOS Accessibility Protocol" or "AX API" for short. I don't recall this even being shortened to just "AX", and in either case, the NSAccessibility link is just one subset portion. This might be the best link in general. https://developer.apple.com/documentation/accessibility Should this be changed elsewhere in HTML-AAM too? Happy to discuss offline since this may be OT for this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I can see looking back to some of the original PRs, this spec has always referred to it as just "AX". i notice though that it is not referred to consistently across AAMs
in the accessibility api sections, HTML AAM refers to it as macOS Accessibility Protocol [AXAPI].
in other many other specs that list out the full name (often in api / important term sections), it's referred to by it's older name - The Mac OS X Accessibility Protocol [AXAPI] - if it's even directly mentioned at all.
in the mapping tables, it's handled like:
dpub AAM - Mac AX API
html aam - AX
core aam, mathml aam - AX API
graphics aam - AXAPI
i have another issue this can be addressed with, at least for html aam
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@scottaohara Would you like me to do raise a separate issue/PR for updating this throughout html-aam?
✅ Deploy Preview for wai-aria ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
fix the link to point to the correct role
@cookiecrook yes, this is an incomplete PR since the attribute isn't in the spec yet. The previous html-aam pr was labeled 'not ready for merge'. |
remove 'not mapped' point to input type=checkbox switch mapping table, and replace other instances of 'not mapped' with 'use wai-aria mapping' text.
Moved from w3c/html-aam#510