-
Notifications
You must be signed in to change notification settings - Fork 131
[html-aam PR 395] add validity IDL #2223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Now pointing to main. |
@scottaohara is this ready for merge if we get a reviewer or is it waiting for implementations? |
@stevefaulkner you didn't happen to make test files for this, did you? |
We don't have tests for html-aam in WPT right now. But this PR was never reviewed, so I added the reviewers from the original PR to this one -- @scottaohara @cookiecrook @cyns can you please take a look? If reviews are positive, lets open an issue on WebKit and merge. |
<td class="uia">Use WAI-ARIA mapping</td> | ||
<td class="atk">Use WAI-ARIA mapping</td> | ||
<td class="ax">Use WAI-ARIA mapping</td> | ||
<td class="comments">If the element has the `validity [IDL]` set and the `aria-invalid` attribute set, User Agents MUST expose only the`validity [IDL]` state.</td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think el.ariaInvalid would stilll need to be exposed… in part because I don't know how to remove it with a HTMLInputElement ILD override, so we could leave it and expose as null. @rahimabdi @annevk what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not entirely clear to me what the requirement here is.
It's also not clear to me why tests couldn't be written for this.
Is the idea that if the form element is considered valid per HTML's requirements, aria-invalid
is to be ignored? I think that should happen on the AT layer and attribute reflection shouldn't really be involved in that. (Thus if you set the aria-invalid
attribute, the ariaInvalid
getter will still reflect that, even if it's valid.)
The Also noting that, per @cookiecrook's comment, it's not possible for user agents to only expose I would propose updating the html-aam spec to state something to the effect of:
Note: The Tracking related issues:
|
I did not mean to suggest to define it in terms of the |
Moved from w3c/html-aam#395
WIP for #394
The following tasks have been completed:
Implementation commitment: