Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARIA IDL updates: convert eligible attributes to enumerated, new ARIA IDL guidance and examples #2413

Open
wants to merge 37 commits into
base: main
Choose a base branch
from

Conversation

rahimabdi
Copy link
Contributor

@rahimabdi rahimabdi commented Jan 24, 2025

Closes #2281
Closes #2279

  • add enumerated attribute definitions for the following attributes including missing value default, invalid value default, keywords/states and canonical keyword:
    • aria-atomic
    • aria-autocomplete
    • aria-busy
    • aria-checked
    • aria-current
    • aria-disabled
    • aria-expanded
    • aria-haspopup
    • aria-hidden
    • aria-invalid
    • aria-live
    • aria-modal
    • aria-multiline
    • aria-multiselectable
    • aria-orientation
    • aria-pressed
    • aria-readonly
    • aria-required
    • aria-selected
    • aria-sort
    • aria-valuemin
    • aria-valuemax
    • aria-valuenow
  • Revise "A. Mapping WAI-ARIA Value types to languages" to include enumerated attributes
  • Revise "6.2.4 Value" for permissible values (remove all other types except "enumerated"?)
  • Update "6.3 ARIA Attributes"
    • Remove obsolete note in "6.3.4 ARIA nullable DOMString Attributes" about ARIA transitioning to non-nullable DOMString?
    • Remote spec guidance around getting/setting to only apply to non-enumerated attributes
    • Provide updated examples for "6.3.4.1 Example Attribute Usage"

Test, Documentation and Implementation tracking

Once this PR has been reviewed and has consensus from the working group, tests should be written and issues should be opened on browsers. Add N/A and check when not applicable.


Preview | Diff

Copy link

netlify bot commented Jan 24, 2025

Deploy Preview for wai-aria ready!

Name Link
🔨 Latest commit 509091f
🔍 Latest deploy log https://app.netlify.com/sites/wai-aria/deploys/67b2de791f08e600088e8a21
😎 Deploy Preview https://deploy-preview-2413--wai-aria.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rahimabdi rahimabdi changed the title ARIA IDL updates (adding keywords/states and missing/invalid values defaults) ARIA IDL updates: add keywords/states and missing/invalid values defaults for eligible attributes Feb 16, 2025
@rahimabdi rahimabdi changed the title ARIA IDL updates: add keywords/states and missing/invalid values defaults for eligible attributes ARIA IDL updates: convert eligible attributes to enumerated Feb 17, 2025
@rahimabdi rahimabdi changed the title ARIA IDL updates: convert eligible attributes to enumerated ARIA IDL updates: convert eligible attributes to enumerated, update IDL guidance and examples Feb 17, 2025
@rahimabdi rahimabdi changed the title ARIA IDL updates: convert eligible attributes to enumerated, update IDL guidance and examples ARIA IDL updates: convert eligible attributes to enumerated, new ARIA IDL guidance and examples Feb 17, 2025
@rahimabdi rahimabdi marked this pull request as ready for review February 19, 2025 00:14
@rahimabdi rahimabdi added Agenda and removed Agenda labels Feb 19, 2025
@rahimabdi rahimabdi marked this pull request as draft February 19, 2025 21:37
@rahimabdi rahimabdi marked this pull request as ready for review February 26, 2025 22:34
@rahimabdi
Copy link
Contributor Author

Adding this PR for discussion at the Feb 27 2025 ARIA WG meeting.

@cookiecrook cookiecrook self-requested a review February 26, 2025 23:08
@@ -99,10 +99,10 @@ caption{
margin:1em 0 0.1em;
padding:0 0 0 0.3em;
}
table.role-features th, table.role-features td, table.state-features th, table.state-features td, table.property-features th, table.property-features td, table.value-descriptions th, table.value-descriptions td {
table.role-features th, table.role-features td, table.state-features th, table.state-features td, table.property-features th, table.property-features td, table.value-descriptions th, table.value-descriptions td, table.state-descriptions th, table.state-descriptions td {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change will cause a conflict with #2410. Could you use a respec class name instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants