Allow comboboxes to invoke menus #2416
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes #2050 This PR simply adds `menu` to the paragraph of text that indicates what value needs to be used for the aria-haspopup attribute, if the popup is not a listbox: >authors MUST specify an aria-haspopup value of tree, grid, or dialog that corresponds to the role of its popup. I think some additional text could be written in the `menu` role definition to further acknowledge this new allowance. But I'll leave that open for discussion, rather than immediately start adding such text.
✅ Deploy Preview for wai-aria ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
scottaohara
commented
Feb 1, 2025
pkra
approved these changes
Feb 1, 2025
SummerJonesTR
approved these changes
Feb 3, 2025
MarioBatusic
approved these changes
Feb 4, 2025
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2050
This PR simply adds
menuto the paragraph of text that indicates what value needs to be used for the aria-haspopup attribute, if the popup is not a listbox:I think some additional text could be written in the
menurole definition to further acknowledge this new allowance. But I'll leave that open for discussion, rather than immediately start adding such text.Test, Documentation and Implementation tracking
Once this PR has been reviewed and has consensus from the working group, tests should be written and issues should be opened on browsers. Add N/A and check when not applicable.
Preview | Diff