-
Notifications
You must be signed in to change notification settings - Fork 711
[css-forms-1] Add UA style rules for text fields #11897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
```css | ||
input:is([type=text], [type=search], [type=email], [type=password], [type=tel], [type=url], [type=number]), | ||
textarea { | ||
display: inline-grid; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should maybe use the modern syntax?
b436f44
to
4a899fb
Compare
|
||
```css | ||
input:not([type]), | ||
input:is([type=text], [type=search], [type=email], [type=password], [type=tel], [type=url], [type=number]), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is every textual input?
4a899fb
to
bb1a516
Compare
color: color-mix(in srgb, currentColor 50%, transparent); | ||
display: none; | ||
line-break: anywhere; | ||
grid-area: 1/1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Used to stack the elements atop each other. Not aware of a way to do this using flex?
} | ||
|
||
::placeholder { | ||
color: color-mix(in srgb, currentColor 50%, transparent); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possibly too low contrast (same would apply to disabled button-like text)
css-forms-1/Overview.bs
Outdated
::field-text { | ||
grid-area: 1/1; | ||
/* Should be cursor width but that's not exposed */ | ||
min-width: 1px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what to do about this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would maybe need adjusting based on this (e.g. using calc-size) #12019 (comment)
cc @mfreed7 due to your comments around flex layout. |
css-forms-1/Overview.bs
Outdated
textarea { | ||
display: inline-grid; | ||
padding-inline: 2px; | ||
field-sizing: content; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we maybe also want to set cursor to text for these?
fddd43a
to
84f8652
Compare
84f8652
to
0c5cee7
Compare
input:is([type=text], [type=search], [type=email], [type=password], [type=tel], [type=url], [type=number]), | ||
textarea { | ||
display: inline-grid; | ||
padding-inline: 2px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be 0.125em? (2/16)
input:is([type=text], [type=search], [type=email], [type=password], [type=tel], [type=url], [type=number]) { | ||
overflow-x: auto; | ||
scrollbar-width: none; | ||
padding-block: 1px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be 0.0625em? (1/16)
|
||
textarea { | ||
overflow-y: auto; | ||
padding-block: 2px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
No description provided.