#311: Don't support Node Expressions as constraint parameters in Core #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajnelson-nist
approved these changes
Apr 14, 2025
YoucTagh
approved these changes
Apr 15, 2025
bergos
approved these changes
Apr 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR only covers Core - removing the previously suggested allowance of node expressions as constraint parameters. Several people had voiced concerns, while others were in general favour. The proposal here is to instead leave this to the Node Expressions document, as a more flexible optional dialect of SHACL.
(Even if this gets approved, I will wait until enough people had a chance to disagree).