Issue 575: Type metaclass members as classes#576
Open
ajnelson-nist wants to merge 5 commits intogh-pagesfrom
Open
Issue 575: Type metaclass members as classes#576ajnelson-nist wants to merge 5 commits intogh-pagesfrom
ajnelson-nist wants to merge 5 commits intogh-pagesfrom
Conversation
Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
This patch ports some of the #575 updates respective of #484's concept renames, and adds other catch-up statements based on the results of this shapes graph run against `shnex.ttl`: ```turtle PREFIX rdf: <http://www.w3.org/1999/02/22-rdf-syntax-ns#> PREFIX rdfs: <http://www.w3.org/2000/01/rdf-schema#> PREFIX sh: <http://www.w3.org/ns/shacl#> <urn:example:shapes:Issue575-shape> a sh:NodeShape ; sh:class rdfs:Class ; sh:targetSubjectsOf rdfs:subClassOf ; . ``` Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
This patch adds explicit class statements based on the results of this shapes graph run against `shnex-shacl.ttl`: ```turtle PREFIX rdf: <http://www.w3.org/1999/02/22-rdf-syntax-ns#> PREFIX rdfs: <http://www.w3.org/2000/01/rdf-schema#> PREFIX sh: <http://www.w3.org/ns/shacl#> <urn:example:shapes:Issue575-shape> a sh:NodeShape ; sh:class rdfs:Class ; sh:targetSubjectsOf rdfs:subClassOf ; . ``` Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
Contributor
Author
|
This PR is now caught up and ready for review. I ran a shapes graph (recorded in Git log) to check for where this pattern applies. |
Contributor
HolgerKnublauch
left a comment
HolgerKnublauch
left a comment
There was a problem hiding this comment.
I am sorry but I don't agree with this change right now. It may be better to wait for input from other people, see the Issue where I explained why I find this triple redundant and we shouldn't repeat ourselves.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #575 .