Skip to content

Conversation

@afs
Copy link
Contributor

@afs afs commented Jan 24, 2026

More syntax tests.
Add wellformedness and stratification test areas.

The file names are not stable - as more tests are added they may fit better along side existing tests which alters the numbering.

Part of #677

At the moment, the syntax tests and wellformedness are generated from a script. This only really matters for syntax tests because there are a lot of them and new tests are likely to affect naming/numbering. To make a PR for new tests, create a new directory and we can combine them when the test suite settles down. When we have a first complete set, scripting shouldn't be needed.

The evaluation tests are hand-crafted so it is possible to make PRs for corrections and new tests now.

@afs afs added the Rules For SHACL 1.2 Rules spec. label Jan 24, 2026
@afs afs force-pushed the afs/rules-tests branch from 103c0a1 to 4493629 Compare January 24, 2026 14:11
@afs afs changed the title More SHACL Rules syntax tests More SHACL Rules tests Jan 25, 2026
@afs afs force-pushed the afs/rules-tests branch from 7f198b4 to 67022b2 Compare January 25, 2026 21:33
@afs afs force-pushed the afs/rules-tests branch from 52edcd6 to e5c50d8 Compare January 27, 2026 09:41
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PREFIX : <http://example/>

:x :q :o

this is missing a .

@simonstey
Copy link
Contributor

this should eventually also add an entry for rules to: https://github.com/w3c/data-shapes/blob/gh-pages/shacl12-test-suite/tests/manifest.ttl right?

@afs afs force-pushed the afs/rules-tests branch from fec0f0e to 3d394ab Compare January 28, 2026 09:15
@afs afs force-pushed the afs/rules-tests branch from 3d394ab to 874198e Compare January 28, 2026 09:18
@afs
Copy link
Contributor Author

afs commented Jan 28, 2026

this should eventually also add an entry for rules to: https://github.com/w3c/data-shapes/blob/gh-pages/shacl12-test-suite/tests/manifest.ttl right?

Unclear.

First - it assumes a system is a complete implementation of all of SHACL (UI? Profiles?). That does not reflect the client/server split.

Second - while at the highest level, they use the same vocabulary, the SHACL 1.0 test framework diverged from the original DataAccess work in the details.

The barrier for rules is that the result graph needs to be compared to a reference graph. Having the input and expected output in one graph does not work. NOT would also makes it "interesting".

@afs afs requested a review from simonstey January 28, 2026 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Rules For SHACL 1.2 Rules spec.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants