Conversation
TallTed
changed the title
HolgerKnublauch
changed the title
bergos
left a comment
bergos
left a comment
There was a problem hiding this comment.
Maybe it's worth mentioning that other constraints define if there are values for the defined properties and how many. Or it could be shown in the example. Since it has some similarities to composite primary keys from SQL, one may expect the values must be sh:minCount == sh:maxCount == 1.
I think that's nice to have for the specification, but it should be covered in a test.
| </div> | ||
| <p><em>The remainder of this section is informative.</em></p> | ||
| <p> | ||
| Note that matching of literals needs to be exact, e.g. <code>"04"^^xsd:byte</code> does not match <code>"4"^^xsd:integer</code>. |
There was a problem hiding this comment.
| Note that matching of literals needs to be exact, e.g. <code>"04"^^xsd:byte</code> does not match <code>"4"^^xsd:integer</code>. | |
| Note that matching of literals needs to be exact, e.g. <code>"04"^^xsd:byte</code> does not match <code>"4"^^xsd:integer</code>. | |
| The same applies to language tags, e.g. <code>"Alice"@en</code> does not match <code>"Alice"@fr</code>. |
I think it would be a good idea to add a note about language tags, too.
For the sh:uniqueLang the TEXTUAL DEFINITION mentions also base direction.
There was a problem hiding this comment.
I had copied that sentence from sh:in, so if we expand on this topic here, we should do this everywhere.
Given that this particular case is just an example ("e.g.") I honestly don't think we need to give another example.
|
@bergos I think I have now addressed your (valid) feedback. Please review again. |
3 participants
Closes #661