Revise dpub note #547
Merged
Revise dpub note #547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes #546 @pkra - I've revised the note. based on your latest github comment, it still seems a warning is in order. using dpub for standard web dev is not the intent of dpub aria, after all. if it was, then then the features would be in ARIA proper :) please let me know if there are any further changes you'd like to see with this note or make any suggested edits you think would make it better. thanks for calling this out and doing some testing.
pkra
approved these changes
Mar 27, 2025
Member
|
Thank you, Scott! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #546
@pkra - I've revised the note. based on your latest github comment, it still seems a warning is in order. using dpub for standard web dev is not the intent of dpub aria, after all. if it was, then then the features would be in ARIA proper :)
please let me know if there are any further changes you'd like to see with this note or make any suggested edits you think would make it better.
thanks for calling this out and doing some testing.
Preview | Diff