Editorial: update figure allowed roles cell

[scottaohara]

closes #497. supersedes #498

---

Preview | Diff

[scottaohara]

@giacomo-petri sorry for the long delay in responding to your prior PR.

I've made some adjustments to what you were suggesting and made this new PR. Please take a look when you can to verify if this restructuring still accomplishes what you had hoped.

[giacomo-petri]

It works, thanks!

Minor tweak: I don't think there are many cases like this, but I'm wondering if there is a simpler way to clarify that the DPUB condition is nested within the if condition.

For example:

If the figure has a valid figcaption descendant:
<ul>
  <li>No role other than ...</li>
  <li>DPUB role: doc-example</li>
</ul>

Otherwise...

I realize that this might require significant effort for consistency with the whole document, so I'm wondering if there's a simpler solution.

That said, it's already clear enough and resolves my main concern with the "if true - if false - else" structure, where the else condition was never applicable. If we come up with a better approach in the future, we can apply it then.

[scottaohara]

thanks @giacomo-petri

yeah, i was thinking about similar - but deferred to just the current structure because it would mean a larger effort to make other instances consistent would need to be made. and per that, i'd much rather do further restructuring to the table (as we started talking about in our last phone conversation) to alleviate such issues, than do a bunch of work and then do other structural changes that would undo that.

so i'm going to leave it for now, but note that your point is understood and valid. thank you.