Skip to content

Conversation

@davidcarlisle
Copy link
Collaborator

As discussed in #388 Core makes scriptlevel global and this adjusts mathml4 to match.

The wording is maybe a little awkward but first thing is to get it adjusted.

this adjusts the wording in the 3.1.6 Displaystyle and Scriptlevel section and deletes the two attributes from the table of mtable attributes (as they are now shared by all presentation)

This PR doesn't adjust the schema (which are in the separate mathml-schema repo) but that was already allowing these everywhere as the presentation mathml schema imports the core one, which defines them as global.

@davidcarlisle davidcarlisle requested a review from NSoiffer March 15, 2025 13:47
Copy link
Contributor

@NSoiffer NSoiffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"if" -> "is (2x) in the following:
Note that if scriptlevel if used with a + or - sign then the effective scriptlevel is incremented or decremented by the value.
If scriptlevel if used with an unsigned integer, the effective scriptlevel is set to that value.

@davidcarlisle
Copy link
Collaborator Author

"if" -> "is (2x) in the following: Note that if scriptlevel if used with a + or - sign then the effective scriptlevel is incremented or decremented by the value. If scriptlevel if used with an unsigned integer, the effective scriptlevel is set to that value.

oops fixed at 82484dd

@NSoiffer NSoiffer merged commit 923d658 into main Mar 28, 2025
1 check passed
github-actions bot added a commit that referenced this pull request Mar 28, 2025
SHA: 923d658
Reason: push, by NSoiffer

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants