Add deviceId as settings and constraints for screen share video tracks. #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
handellm
reviewed
Dec 19, 2024
|
|
||
| <td> | ||
| The identifier of the surface being captured. | ||
|
|
There was a problem hiding this comment.
Judging from the preview, to me I find it incredibly hard to read given the current line breaks. Also the following bullet is hard to read. Concatenate sentences?
There was a problem hiding this comment.
It seems there is a rendering bug somewhere: the preview is not showing the black rectangle around the block like the main spec does (see https://w3c.github.io/mediacapture-screen-share/#dfn-displaysurface).
The current separation mirrors what has been done for displaySurface.
That said displaySurface is the outlier here, all other constraints concatenate sequences.
I am fine concatenating.
youennf
commented
Dec 19, 2024
jan-ivar
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #308
Preview | Diff