Skip to content

Update Regexp for Ending #588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mscuthbert wants to merge 3 commits into from
Closed

Update Regexp for Ending #588

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2d468bb
Update Regexp for Ending
mscuthbert May 23, 2025
e00f53e
Opposite direction, thanks mdgood.
mscuthbert May 24, 2025
075b6d0
has -> had
mscuthbert May 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
93 changes: 54 additions & 39 deletions docs/version-history/41/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,45 +105,60 @@

<h1>Version 4.1 (Draft)</h1>

<h2>Draft: 2025</h2>

<h2 id="schema">Schema Additions</h2>

<h3 id="elements">New Elements</h3>

<ul>
<li>None so far</li>
<!-- 4.0 example... <li>The <a href="../../musicxml-reference/elements/assess/">&lt;assess&gt;</a> element specifies how default assessment should be overridden for individual notes. (<a href="https://github.com/w3c/musicxml/issues/294">#294</a>)</li> -->
</ul>

<h3 id="attributes">New Attributes</h3>

<ul>
<li>None so far</li>

<!-- <li>The above attribute has been added to the <a href="../../musicxml-reference/elements/double/">&lt;double&gt;</a> element. (<a href="https://github.com/w3c/musicxml/issues/368">#368</a>)</li> -->

</ul>

<h3 id="values">New Values</h3>

<ul>
<li>None so far</li>
<!-- <li>The <a href="../../musicxml-reference/data-types/smufl-accidental-glyph-name/">smufl-accidental-glyph-name</a> type used by the smufl attribute of the <a href="../../musicxml-reference/elements/accidental/">&lt;accidental&gt;</a>, <a href="../../musicxml-reference/elements/accidental-mark/">&lt;accidental-mark&gt;</a>, <a href="../../musicxml-reference/elements/accidental-text/">&lt;accidental-text&gt;</a>, and <a href="../../musicxml-reference/elements/key-accidental/">&lt;key-accidental&gt;</a> elements now allows SMuFL accidental glyphs from the <a href="https://www.w3.org/2021/03/smufl14/tables/medieval-and-renaissance-accidentals.html">Medieval and Renaissance accidentals</a> and <a href="https://www.w3.org/2021/03/smufl14/tables/kievan-square-notation.html">Kievan square notation</a> ranges. (<a href="https://github.com/w3c/musicxml/issues/330">#330</a>)</li> -->

</ul>

<h2 id="deprecated">Removed and Deprecated Features</h2>

<ul>
<li><i>(Deprecated in 4.0, to be removed in 5.0)</i>: <li>The DTD versions of the MusicXML definitions have been deprecated in favor of the XSD versions. This includes the midixml DTD and XSL files, which will not be replaced with XSD versions. (<a href="https://github.com/w3c/musicxml/issues/401">#401</a>)</li>
</ul>

<h2 id="documentation">Documentation Changes</h2>

<ul>
<li>Errors in the docs for <code>accordion-middle, circular-arrow, interchangeable, inversion,</code> and <code>voice</code> have been fixed (<a href="https://github.com/w3c/musicxml/issues/496">#496</a>)
<li>Musical errors in the XML and Image on the Fauré example have been fixed. (<a href="https://github.com/w3c/musicxml/issues/500">#500</a>)</li>
<h2>Draft: 2025</h2>

<h2 id="schema">Schema Additions</h2>

<h3 id="elements">New Elements</h3>

<ul>
<li>None so far</li>
<!-- 4.0 example... <li>The <a href="../../musicxml-reference/elements/assess/">&lt;assess&gt;</a> element specifies how default assessment should be overridden for individual notes. (<a href="https://github.com/w3c/musicxml/issues/294">#294</a>)</li> -->
</ul>

<h3 id="attributes">New Attributes</h3>

<ul>
<li>None so far</li>

<!-- <li>The above attribute has been added to the <a href="../../musicxml-reference/elements/double/">&lt;double&gt;</a> element. (<a href="https://github.com/w3c/musicxml/issues/368">#368</a>)</li> -->

</ul>

<h3 id="values">New Values</h3>

<ul>
<li>None so far</li>
<!-- <li>The <a href="../../musicxml-reference/data-types/smufl-accidental-glyph-name/">smufl-accidental-glyph-name</a> type used by the smufl attribute of the <a href="../../musicxml-reference/elements/accidental/">&lt;accidental&gt;</a>, <a href="../../musicxml-reference/elements/accidental-mark/">&lt;accidental-mark&gt;</a>, <a href="../../musicxml-reference/elements/accidental-text/">&lt;accidental-text&gt;</a>, and <a href="../../musicxml-reference/elements/key-accidental/">&lt;key-accidental&gt;</a> elements now allows SMuFL accidental glyphs from the <a href="https://www.w3.org/2021/03/smufl14/tables/medieval-and-renaissance-accidentals.html">Medieval and Renaissance accidentals</a> and <a href="https://www.w3.org/2021/03/smufl14/tables/kievan-square-notation.html">Kievan square notation</a> ranges. (<a href="https://github.com/w3c/musicxml/issues/330">#330</a>)</li> -->

</ul>

<h3 id="values">Changed Attributes/Values</h3>
<ul>
<li>The <a href="../../musicxmlreference/data-types/ending-number/">ending-number</a> type used
in the <code>number</code> attribute of the
<a href="../../musicxml-reference/elements/ending/">&lt;ending&gt;</a>, previously had a regex
that implied that empty spaces were different from the empty string. This has been clarified.
Copy link
Contributor

@lemzwerg lemzwerg May 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'Empty spaces' sounds like a pleonasm 🙂

I suggest to replace this with 'a sequence of consecutive space characters' or something like that.

</li>
</ul>


<h2 id="deprecated">Removed and Deprecated Features</h2>

<ul>
<li><i>(Deprecated in 4.0, to be removed in 5.0)</i>: <li>The DTD versions of the MusicXML definitions have been deprecated in favor of the XSD versions. This includes the midixml DTD and XSL files, which will not be replaced with XSD versions. (<a href="https://github.com/w3c/musicxml/issues/401">#401</a>)</li>
</ul>

<h2 id="documentation">Documentation Changes</h2>

<ul>
<li>Errors in the docs for <code>accordion-middle, circular-arrow, interchangeable, inversion,</code> and <code>voice</code> have been fixed (<a href="https://github.com/w3c/musicxml/issues/496">#496</a>)
<li>Musical errors in the XML and Image on the Fauré example have been fixed. (<a href="https://github.com/w3c/musicxml/issues/500">#500</a>)</li>
<li>The <a href="../../musicxmlreference/data-types/ending-number/">ending-number</a> type used
in the <code>number</code> attribute of the
<a href="../../musicxml-reference/elements/ending/">&lt;ending&gt;</a>, previously had documentation
implying that empty spaces were different from the empty string. This has been clarified.
</li>
</ul>

</main>
Expand Down
5 changes: 3 additions & 2 deletions schema/musicxml.xsd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -885,10 +885,11 @@ The none sign is deprecated as of MusicXML 4.0. Use the clef element's print-obj

<xs:simpleType name="ending-number">
<xs:annotation>
<xs:documentation>The ending-number type is used to specify either a comma-separated list of positive integers without leading zeros, or a string of zero or more spaces. It is used for the number attribute of the ending element. The zero or more spaces version is used when software knows that an ending is present, but cannot determine the type of the ending.</xs:documentation>
<xs:documentation>The ending-number type is used to specify either a comma-separated list of positive integers without leading zeros, or the empty string. It is used for the number attribute of the ending element.
The empty-string version is used when software knows that an ending is present, but cannot determine the type of the ending.</xs:documentation>
</xs:annotation>
<xs:restriction base="xs:token">
<xs:pattern value="([ ]*)|([1-9][0-9]*(, ?[1-9][0-9]*)*)"/>
<xs:pattern value="()|([1-9][0-9]*(, ?[1-9][0-9]*)*)"/>
Copy link
Contributor

@lemzwerg lemzwerg May 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think it makes sense to change ' ?' to '[ ]?' to increase readability.

</xs:restriction>
</xs:simpleType>

Expand Down