Consume user activation when requesting PiP#246
Merged
Conversation
beaufortfrancois
force-pushed
the
consume-user-activation
branch
from
0956aff to
16fd99e
Compare
Contributor
|
Looks good to me! |
marcoscaceres
approved these changes
Feb 26, 2026
marcoscaceres
left a comment
marcoscaceres
left a comment
Member
There was a problem hiding this comment.
Looks good, but, as a follow up, we should do an editorial cleanup of this later to pass in the promise instead of throwing - and reject the promise in place.
Also, just nits... but should be [=exception/throw=] a {{NotAllowedError}} {{DOMException}}. See examples:
https://webidl.spec.whatwg.org/#example-exception-creation-and-throwing
We can clean all that up later tho. No biggy.
Collaborator
Author
|
Since this change will be reflected in #245, I'll go ahead and merge this PR. We'll do the editorial cleanup in @theIDinside's PR. |
github-actions Bot
added a commit
that referenced
this pull request
Feb 26, 2026
SHA: 2983289 Reason: push, by beaufortfrancois Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
theIDinside
added a commit
to theIDinside/picture-in-picture
that referenced
this pull request
Mar 3, 2026
theIDinside
added a commit
to theIDinside/picture-in-picture
that referenced
this pull request
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raised in #245 (comment), this PR adds missing "Consume user activation when requesting PiP" as tested in Web Platform Tests.
@theIDinside @marcoscaceres
Preview | Diff