-
Notifications
You must be signed in to change notification settings - Fork 4
Update figure style of triple terms #168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
2207f62
Enable dark mode and update CSS of figure element
niklasl e61ba09
Align SVG figures with Primer and enable dark mode
niklasl 47a2ab9
Update triple term figure descriptions
niklasl fea7226
Remove links to old figure versions on google docs
niklasl c77a558
Only force color-scheme through user-checked input
niklasl 8db3d88
Improve SVG figure rendering for WebKit
niklasl dfd4025
Move object fallback text to aria-label attribute
niklasl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
:root { --bg: #fff; --solid: #eee; --abstract: #aaa; --fg: #000 } | ||
@media (prefers-color-scheme: dark) { | ||
:root { --bg: #000; --solid: #333; --abstract: #777; --fg: #eee } | ||
} | ||
svg { background-color: var(--bg); stroke: none } | ||
ellipse { stroke: var(--fg); fill: var(--solid) } | ||
path.arrow { stroke: var(--fg); marker-end: url(#arrowhead) } | ||
#arrowhead { fill: var(--fg) } | ||
text { fill: var(--fg); font-family: Helvetica, sans-serif } | ||
text.middle { text-anchor: middle } | ||
text.italic { font-style: italic } | ||
path.reifies { stroke: var(--fg); stroke-width: 1; marker-start: url(#arrowhead); fill: none } | ||
.abstract > path.arrow { stroke: var(--abstract); stroke-dasharray: 8; marker-end: url(#arrowhead-abstract) } | ||
#arrowhead-abstract { fill: var(--abstract) } | ||
.abstract > text { fill: var(--abstract) } | ||
.unlinked > ellipse { stroke: var(--abstract) } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside: I guess this is something that should be part of tr-design stylesheet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. I think this solves the JS-dependency problem you noted, but is still sensitive to structural ReSpec changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed. But if it's ship in tr-design alongside the definition of the selector then I guess it's fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've proposed to add this to ReSpec (in speced/respec#4925), since that's where the tr-design CSS and JS is referenced. (And further coordinating what goes where can follow suite in that PR.) For the the sake of the SVGs I'll merge with this left in (functionally equivalent to what's in that PR), and will follow up with a cleanup once the general fix lands in ReSpec.