Merged
Conversation
I'm not quite sure where plain "engines" should be coming from when looking into this file. I'm pretty sure it needs to be `packageConfig.engines` otherwise I can't even run the script on my machine.
dontcallmedom
approved these changes
Feb 4, 2025
tidoust
added a commit
that referenced
this pull request
Feb 4, 2025
Bug fixed: - Fix unknown variable (#1765) Dependencies bumped: - Bump rollup from 4.31.0 to 4.34.2 (#1766) - Bump puppeteer from 24.1.0 to 24.1.1 (#1759) - Bump semver from 7.6.3 to 7.7.1 (#1767) - Bump mocha from 11.0.1 to 11.1.0 (#1757) - Bump undici from 7.2.3 to 7.3.0 (#1756) - Bump web-specs from 3.35.0 to 3.37.0 (#1763)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not quite sure where plain "engines" should be coming from when looking into this file. I'm pretty sure it needs to be
packageConfig.enginesotherwise I can't even run the script on my machine.This probably hasn't been noticed before, as everyone ran the script with the correct version.