Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renames 'RDFterm-equal' to 'sameValue' #197

Closed
wants to merge 1 commit into from
Closed

Renames 'RDFterm-equal' to 'sameValue' #197

wants to merge 1 commit into from

Conversation

hartig
Copy link
Contributor

@hartig hartig commented Feb 18, 2025

As discussed in #25, renames the RDFterm-equal function to sameValue. Also, as suggested by @afs, this PR adds a legacy anchor (with an HTML comment that this is anchor is obsolete now, as done for similar cases in RDF-Concepts)

For the sake of keeping this PR small and focused, it does not include any changes to the definition of the renamed function (as are currently discussed in #187, and also related to #182).

Closes #25


Preview | Diff

@hartig hartig requested review from kasei, afs, rubensworks and Tpt February 18, 2025 14:08
@afs
Copy link
Contributor

afs commented Feb 18, 2025

This will conflict with #194 which reorders the sections.

@hartig
Copy link
Contributor Author

hartig commented Feb 18, 2025

This will conflict with #194 which reorders the sections.

Ah! I didn't pay attention to #194, probably because it is marked as draft. Sorry!!

In this case, I will keep this PR open for the moment but are ready to drop it if we decide to go forward with #194 (for which I would have preferred it didn't contain both the change of the order of the sections and the change of the definition of RDFterm-equal).

@afs
Copy link
Contributor

afs commented Feb 18, 2025

I don't think we have decided whether to have sameValue in the grammar or not.

@afs
Copy link
Contributor

afs commented Feb 18, 2025

(for which I would have preferred it didn't contain both the change of the order of the sections and the change of the definition of RDFterm-equal).

Sorry, but there are overheads when there are chains PRs.

@hartig
Copy link
Contributor Author

hartig commented Feb 18, 2025

I don't think we have decided whether to have sameValue in the grammar or not.

The change in this PR is not about adding anything to the grammar but only about changing the name of the function that is used to define = in the last two cases in the operator mapping table. I know that you also proposed to consider supporting this function directly as a new keyword, but as I saw this as an orthogonal question, I didn't include it in this PR.

@hartig
Copy link
Contributor Author

hartig commented Feb 18, 2025

Sorry, but there are overheads when there are chains PRs.

Understood.

@afs
Copy link
Contributor

afs commented Feb 24, 2025

After trying to apply this to #194 and finding the patch does not apply - and there new uses of RDFterm-equal in #194 -
I've copied changes into #194.

There are now two uses of the string RDFterm-equal - the obsolate anchor and the "Changes" entry.

@afs
Copy link
Contributor

afs commented Mar 6, 2025

This is carried out in #194 which is in the same area.

@afs afs closed this Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename 'RDFterm-equal'
4 participants