Skip to content

fix grammar, punctuation, some whitespace#10

Closed
TallTed wants to merge 4 commits into
w3c:mainfrom
TallTed:patch-1
Closed

fix grammar, punctuation, some whitespace#10
TallTed wants to merge 4 commits into
w3c:mainfrom
TallTed:patch-1

Conversation

@TallTed

@TallTed TallTed commented Jul 15, 2024

Copy link
Copy Markdown
Member

follows on the quickly merged #9


Preview | Diff

follows on the quickly merged w3c#9
@msporny

msporny commented Jul 23, 2024

Copy link
Copy Markdown
Member

@wes-smith can you try to resolve these conflicts? We do want to pull @TallTed's fixes in (but the commits to main have made it difficult to pick out the refactoring of the test vectors from @TallTed's changes. You might be the best person to pick through the merge conflicts. If not, we'd have to ask @TallTed to re-do his change suggestions, which would have him (more or less) starting over w/ a new PR.

@msporny

msporny commented Jun 4, 2025

Copy link
Copy Markdown
Member

@TallTed could you please attempt to resolve conflicts here or decide to raise a new PR. We do want to get these fixes into the spec.

@TallTed

TallTed commented Jun 5, 2025

Copy link
Copy Markdown
Member Author

I believe (I hope) the merge above has fixed all the conflicts, and included my earlier changes where they hadn't already been made (or obviated) by someone else.

Comment thread index.html Outdated
Comment thread index.html Outdated
@TallTed TallTed requested review from davidlehn and msporny June 17, 2025 20:56
@BigBlueHat

Copy link
Copy Markdown
Member

This one looks "overtaken by events". I'd suggest we close it and do another grammar pass soon.

@davidlehn davidlehn mentioned this pull request Mar 17, 2026
@davidlehn

Copy link
Copy Markdown
Contributor

This one looks "overtaken by events". I'd suggest we close it and do another grammar pass soon.

Overtaken how? Let's not redo the work from this PR. A rebase exploded on me for some reason, but it was easy to move all the changes over. And fix some more things: https://github.com/w3c-ccg/vc-barcodes/pull/29.

@davidlehn

Copy link
Copy Markdown
Contributor

Changes applied in https://github.com/w3c-ccg/vc-barcodes/pull/29.
This can be closed.

@TallTed

TallTed commented Mar 20, 2026

Copy link
Copy Markdown
Member Author

Fixed (three, small) conflicts, to make it easier to confirm that all changes suggested here were applied in #29.

@TallTed

TallTed commented Mar 20, 2026

Copy link
Copy Markdown
Member Author

Confirmed. Closing as redundant.

@TallTed TallTed closed this Mar 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants