Add selective disclosure example and conversion pseudo code#624
Open
PatStLouis wants to merge 2 commits into
Open
Add selective disclosure example and conversion pseudo code#624PatStLouis wants to merge 2 commits into
PatStLouis wants to merge 2 commits into
Conversation
Add normative-style algorithm prose and pseudo-code for converting a QueryByExample example into JSON pointers (incl. prune and type handling). Incorporates review feedback from #572 (msporny wording; TallTed < escape). Addresses #545 Refs #572 Signed-off-by: Patrick St-Louis <patrick.st-louis@opsecid.ca> Made-with: Cursor
TallTed
reviewed
Apr 14, 2026
| standardized way to perform this conversion: | ||
| </p> | ||
|
|
||
| <ol> |
Member
There was a problem hiding this comment.
Should this be classed algorithm and use the algorithm-specific CSS used elsewhere?
Apply spec algorithm list styling (TallTed review on PR). Signed-off-by: Patrick St-Louis <patrick.st-louis@opsecid.ca> Made-with: Cursor
|
msporny marked as non substantive for IPR from ash-nazg. |
|
msporny marked as substantive for IPR from ash-nazg. |
PatStLouis
commented
Apr 14, 2026
| The following is a reference implementation of this algorithm: | ||
| </p> | ||
|
|
||
| <pre class="example" title="Algorithm to convert QueryByExample example to JSON pointers"> |
Collaborator
Author
There was a problem hiding this comment.
convert to an actual algorithm (normative), using the algorithm class. Avoid pseudo code in favor of a normative algorithm.
Collaborator
Author
There was a problem hiding this comment.
review: https://w3c.github.io/vc-data-integrity/#add-proof for example of existing algorithms in respec
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
Under Query by example, this adds a subsection (Converting QueryByExample to JSON Pointers) that explains how to turn a QueryByExample
exampleinto a list of JSON pointers for selective disclosure. It spells out the intended steps (including handling@context, mandatory VCDM pointers,credentialSubject, pruning to deepest pointers, and normalizingtypepointers) and includes reference pseudo-code for the conversion and pruning logic.Context
mainline.Review feedback already incorporated (from #572)
<pre>: use<for the less-than comparison so the line is not parsed as HTML in viewers that syntax-highlight the file.Closes #545
Refs #572