-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3984 labels descriptions #4212
base: main
Are you sure you want to change the base?
3984 labels descriptions #4212
Conversation
put Success Criterion lower case except where it specifies a number, as per https://github.com/w3c/wcag/wiki/WCAG-2-style-guide
This reverts commit 7bdeee0.
change "this" to "that"; made dashes be em dashes (without spaces)
✅ Deploy Preview for wcag2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
added "accuracy" to several examples and passages
A semi-colon would be a more appropriate separator than a dash or hyphen. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see no improvement changing xxx - xxx
to xxx-xxx
.
for context, the change here uses an actual |
x-ref #4096 |
discussed in backlog meeting - opted to reintroduce the spaces around the |
I refreshed my mind on the original issue this tries to address, #3984 - i'd say this SC covers the concern now in a fairly clear way (it still doesn't "reintroduce" the need for accuracy to 3.3.2, but reinforces it - or at least name-checks it - in 2.4.6 now). in short, LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would suggest more gracefully embedding the cross-reference to 3.3.2, rather than in an parenthetical
Update to swap out sentences in second paragraph, as discussed on TF call
Discussed on backlog call 3/7. Kept in Drafted. |
Closes #3984 by incorporating the idea of accuracy into 2.4.6 Headings and Labels, and reinforcing the relationship between 2.4.6 and 3.3.2 Labels or Instructions.
Also took the opportunity to use em dashes instead of dashes, where appropriate.