Expand consistent navigation understanding intent #4833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The intent currently leans heavily on visual layout/presentation ... but then almost in passing in the "Benefits..." section just mentions users who are blind. The only way users who are blind would benefit (if that was the intention) is if this is not just about visual order, but also source order. Assuming that that's the case (that this was the intention), this PR makes it much more explicit in the intention. Closes #2133
✅ Deploy Preview for wcag2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intent currently leans heavily on visual layout/presentation ... but then almost in passing in the "Benefits..." section just mentions users who are blind. (this is likely because, back when this was written, there was a tacit assumption that of course, visual layout and source order are the same?)
The only way users who are blind would benefit (if that was the intention) is if this is not just about visual order, but also source order. Assuming that that's the case (that this was the intention), this PR makes it much more explicit in the intention.
Closes #2133