Update footer design to match the WAI website's #4850
Conversation
✅ Deploy Preview for wcag2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
This looks good to me. If Ken is happy I can do an understanding and techniques update this Thurs. |
|
kfranqueiro marked as non substantive for IPR from ash-nazg. |
xslt/base.xslt
Outdated
| <div class="wai-global-footer__cta w3c-l-cluster w3c-l-cluster--vertical-align"> | ||
| <ul class="w3c-clean-list" role="list"> | ||
| <li class="w3c-with-icon--before w3c-with-icon--larger"> | ||
| <img class="w3c-icon w3c-icon--larger" src="https://www.w3.org/WAI/assets/images/email.svg" width="30" height="30" alt="" aria-hidden="true"> |
There was a problem hiding this comment.
I'm not sure we should even worry about what's in base.xslt, as it has probably already missed a few prior updates (it hasn't been updated since I started working here). Moreover, it looks like the code pasted here would not be valid XML, such as this non-self-closing img tag, which is why I suggest we leave it out.
I had previously gone through and removed parts of the XSLT that we definitely weren't using anymore; maybe I should remove more of it... cc @iadawn
There was a problem hiding this comment.
Yes, we can ignore base.xslt... or indeed any XSLT ... please, please? :)
There was a problem hiding this comment.
it looks like the code pasted here would not be valid XML, such as this non-self-closing img tag, which is why I suggest we leave it out.
Indeed, thanks for flagging!
I'm not sure we should even worry about what's in base.xslt, as it has probably already missed a few prior updates
I guess the only question I have is: if we don't update this file, will some pages still display the old footer?
There was a problem hiding this comment.
Nope, we have relied exclusively on the Eleventy build for roughly 18 months at this point. I partially cleaned out parts of the XSLT that I knew for sure we would never use again but had left any build tasks I'd had doubts about; I'm suspecting we don't have a use for any of what's remaining at this point, either.
There was a problem hiding this comment.
Thanks @kfranqueiro I've reverted the changes made to base.xslt at this point.
This applies the same footer design as on the WAI website.
Related to w3c/wai-website-theme#163.