You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The WCAG 2.2 guidelines include markup to denote new additions, consisting of an extra paragraph above the actual content. They also include a ReSpec post-processing script that adds titles to definition links based on the first child element of the next sibling after the definition term. Together, these two create a problem.
This change revises the logic used by the post-process script to skip the extra paragraph denoting "New" definitions (which it was previously exclusively using).
Note this same issue would technically exist in 2.1, but we do not use the "New" annotation anywhere in that version.
I diffed a ReSpec export before/after and only the title attributes for terms whose definitions include the "New" paragraph are affected.
To experience the defect with published version, go to any SC using a new glossary term and inspect the title. Visually, most browsers will display the title attribute on mouse-over hover.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3511.
The WCAG 2.2 guidelines include markup to denote new additions, consisting of an extra paragraph above the actual content. They also include a ReSpec post-processing script that adds titles to definition links based on the first child element of the next sibling after the definition term. Together, these two create a problem.
This change revises the logic used by the post-process script to skip the extra paragraph denoting "New" definitions (which it was previously exclusively using).
Note this same issue would technically exist in 2.1, but we do not use the "New" annotation anywhere in that version.
I diffed a ReSpec export before/after and only the
titleattributes for terms whose definitions include the "New" paragraph are affected.