Skip to content

Skip "New" paragraph when scanning definitions to make link titles#4857

Open
kfranqueiro wants to merge 5 commits intomainfrom
kgf-dfn-links-fix-new
Open

Skip "New" paragraph when scanning definitions to make link titles#4857
kfranqueiro wants to merge 5 commits intomainfrom
kgf-dfn-links-fix-new

Conversation

@kfranqueiro
Copy link
Contributor

@kfranqueiro kfranqueiro commented Jan 13, 2026

Fixes #3511.

The WCAG 2.2 guidelines include markup to denote new additions, consisting of an extra paragraph above the actual content. They also include a ReSpec post-processing script that adds titles to definition links based on the first child element of the next sibling after the definition term. Together, these two create a problem.

This change revises the logic used by the post-process script to skip the extra paragraph denoting "New" definitions (which it was previously exclusively using).

Note this same issue would technically exist in 2.1, but we do not use the "New" annotation anywhere in that version.

I diffed a ReSpec export before/after and only the title attributes for terms whose definitions include the "New" paragraph are affected.

@netlify
Copy link

netlify bot commented Jan 13, 2026

Deploy Preview for wcag2 ready!

Name Link
🔨 Latest commit 9dff8a0
🔍 Latest deploy log https://app.netlify.com/projects/wcag2/deploys/69a5be2d00d0c600084ebe2f
😎 Deploy Preview https://deploy-preview-4857--wcag2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@patrickhlauke
Copy link
Member

great stuff. as a test/preview, go to https://deploy-preview-4857--wcag2.netlify.app/guidelines/#accessible-authentication-minimum and check the title of "cognitive function test" - then go to https://deploy-preview-4857--wcag2.netlify.app/guidelines/#dfn-cognitive-function-test and note that there's a "NEW" at the start of it. the latter isn't included in the former anymore.

@kfranqueiro kfranqueiro added the ErratumRaised Potential erratum for a Recommendation label Jan 14, 2026
@bruce-usab bruce-usab self-assigned this Jan 16, 2026
@bruce-usab
Copy link
Contributor

Concurrence on TF call 1/16. TF facilitators to discuss disposition (which column) on next coordination call.

@patrickhlauke
Copy link
Member

Note: while this will be included in the list of fixes under errata, this is essentially a bug fix

@bruce-usab
Copy link
Contributor

bruce-usab commented Feb 2, 2026

To experience the defect with published version, go to any SC using a new glossary term and inspect the title. Visually, most browsers will display the title attribute on mouse-over hover.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Fixes ErratumRaised Potential erratum for a Recommendation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

References to New WCAG 2.2 definitions are setting "New" as title instead of the definition

4 participants