-
Notifications
You must be signed in to change notification settings - Fork 379
Update 1.4.3 and 1.4.6 to include references to text in video #4927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
patrickhlauke
wants to merge
6
commits into
main
Choose a base branch
from
fstorr-update-contrasts-with-video
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
a969c00
update 1.4.3 and 1.4.5 to include references to text in video
fstrr 466047c
Merge branch 'main' into fstorr-update-contrasts-with-video
patrickhlauke fc1b07b
Apply suggestion from @patrickhlauke
patrickhlauke 05dd56a
Apply suggestion from @patrickhlauke
patrickhlauke 961abfc
Re-port original changes after fixing merge conflicts
patrickhlauke 1ade8eb
Merge branch 'main' into fstorr-update-contrasts-with-video
kfranqueiro File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👎 I don't think this has enough detail to make this understanding doc clear about the scope. The SC applies specifically to "The visual presentation of text and images of text"; text in videos can qualify as image of text, but often doesn't. The "image of text" definition is:
I think this definition suggests that if you had a video that was "I animated the word 'Sale!' bouncing from side to side", that would be in scope, but if you had a video where a low-contrast street sign happened to be part of a movie scene, that would not be in scope.
I think most text in videos in practice would not be in scope, so I think we should be more clear than this update suggests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It occurs to me that “A person‘s name on nametag is a photograph” could be read as being an example of images of text — when the opposite is intended!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And to @dbjorge good point on call wrt captioning -- those often are actual text (not images of text). With digital TVs and modern closed captioning, sufficient contrast is guaranteed because modern TVs let one pick foreground and background colors (and other settings, including font). The source media lacking CC data is addressed by other SC.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are certainly plenty of videos like that, but most or all of the text would be in scope in many of the videos we encounter. This includes opening credits, title frames between scenes, and multiple end cards that can contain a large amount of information. Important text is often displayed throughout educational videos and animations. And some clients still create videos with open captions.