Remove G200, tweak G201 to apply to links and buttons, fix association of the technique with appropriate SCs#4955
Remove G200, tweak G201 to apply to links and buttons, fix association of the technique with appropriate SCs#4955giacomo-petri wants to merge 25 commits intomainfrom
Conversation
✅ Deploy Preview for wcag2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Hey @kfranqueiro, I'm not allowed to access the logs. Can you please double-check why the preview cannot be deployed? Thanks |
Co-authored-by: Patrick H. Lauke <redux@splintered.co.uk>
Looks like the spec-generator invocations failed, and looks like the reason why might be a new front-loaded "are you sure?" step that GitHack added. I might need to do something about that separately. This doesn't mean there's anything wrong with the PR. FYI, I recently added the "Build PR / Run build" check which also performs the build of the informative docs, so if you see that passing, you should be safe. (Doesn't resolve that there's currently no preview though.) |
pointless "technique" with one fairly debatable example (the session logout/security aspect)
|
@patrickhlauke, it looks like the following section may have been accidentally removed: I think restoring it would be helpful, as it clarifies the final note in this issue description. |
|
as the question came up in #1779 about what the difference is between 3.2.2 On Input and 3.2.5 Change on Request ... for 3.2.2, one way of satisfying the requirements of the SC is to "warn" the user - this "if you warn the user, it's not a problem" escape clause is not present in 3.2.5 Change on Request, which demands that you must have a mechanism to prevent unexpected changes of context. for this reason, G201 is not sufficient for 3.2.5, but only advisory. (note that the clarification about the potential overlap, but also the difference, between 3.2.5 and 3.2.2 that #1779 raises will be dealt with in a separate PR) |
Done (after I initially thought it was sufficient for 3.2.5, but then realised it's advisory for that one too) |
|
Discussed on TF call 27 Feb, keeping in Drafted for now. |
Co-authored-by: Adam Page <adam@adampage.net>
Co-authored-by: Adam Page <adam@adampage.net>
Closes #4043
Closes #4197
EDIT: (@patrickhlauke : having discussed this with @giacomo-petri separately, went ahead to make some more fundamental tweaks here)
Making G201 advisory for 2.4.4/2.4.6/2.4.9 hopefully also signals how it's a nice to have for those SCs, but not required (hopefully?), which answers another perennial question i see bubbling up ("there's a link that opens a new window, can i fail it because it doesn't have an icon/text that says it opens in a new window?")