Open
Conversation
Also: 1. Add `autocomplete` attributes 2. Removed 404 resource link 3. Removed old editors CSS link 4. Added `code` tags 5. Updated the list of errors to use a list instead of 3 paragraphs
✅ Deploy Preview for wcag2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
1. removed the jQuery and rewrote using vanilla JavaScript 2. Removed several unused functions 3. simplified the date validity field 4. added a replacement image for the one that was missing 5. removed an unnecessary `alert` role 6. moved explanatory content to the technique 7. removed out of date assistive technology information
Contributor
Author
Identifying Errors In Data Format example
|
1. removed jQuery 2. added CSS 3. removed the `focus` functionality for the error message—there’s no point in having a live region with that present 4. added `autocomplete` attributes 5. removed the empty `h2` element 6. moved the error message inside the form 7. slightly tweaked the content of the error message
1. Remove outdated content 2. Update examples to add `autocomplete` attributes 3. Updated resource links 4. Split the example code into separate `pre` blocks
1. remove jquery 2. add `viewport` 3. update css to use modern positioning 4. add `inert` attribute
Contributor
Author
ARIA21
|
Contributor
Author
ARIA18Updated HTML snippet to use updated working example code Working example:
|
fstrr
added
Techniques
1.1.1 Non-text content
Working Examples
and removed
1.1.1 Non-text content
labels
Member
|
Moved this back into "In progress", as this will likely need considerable untangling once #4980 lands (possibly to the point where it might be quicker to just redo the PR as a fresh one) |
Member
|
out of interest, i did try a naive "rebase this against the other branch from #4980" but it ended up with merge conflicts all over the shop... so it may indeed be easier to just do a fresh PR that only touches the jquery stuff and nothing else, cleanly. may have a go at it tomorrow... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ARIA 19
autocompleteattributescodetags