Update redirect handling for DBSC requests #168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current description doesn't really align with the Fetch redirect handling. While it's nice to ensure that sites don't expose themselves to significant risk, we already require that the refresh URL be HTTPS, so sites need to do significant work to take on this risk. Simpler Fetch integration is valued over protecting sites from themselves.
thefrog-gh
approved these changes
May 7, 2025
github-actions bot
added a commit
that referenced
this pull request
May 7, 2025
SHA: 79f3d0f Reason: push, by drubery Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current description doesn't really align with the Fetch redirect handling. While it's nice to ensure that sites don't expose themselves to significant risk, we already require that the refresh URL be HTTPS, so sites need to do significant work to take on this risk. Simpler Fetch integration is valued over protecting sites from themselves.