Describe session key sharing mechanism #171
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thefrog-gh
reviewed
May 7, 2025
spec.bs
Outdated
| 1. If |algorithm list| is empty, return null. | ||
| 1. Let |unshared key| be a key pair created for |algorithm list|. | ||
| 1. If any of |params|["provider_key"], |params|["provider_id"], or | ||
| |params|["provider_site"] exists: |
There was a problem hiding this comment.
Do we want provider_site or provider_origin? We use provider_origin in the section "Secure-Session-Registration HTTP header field"
There was a problem hiding this comment.
Yeah this is inconsistent because I went back and forth and seems like I didn't quite settle on either. I was struggling with two things:
- How do we lookup the session given the
originandsession id. - How do we get the well-known URL from
origin.
I think we want to have that field be a URL, from which we can easily derive the site (as the registrable domain), expected origin, and well-known URL. Therefore I've renamed it "provider_url". Let me know what you think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.