Use "domain pattern" to refer to patterns in scope specifications#244
Merged
Use "domain pattern" to refer to patterns in scope specifications#244
Conversation
thefrog-gh
approved these changes
Feb 13, 2026
spec.bs
Outdated
| : <dfn>host</dfn> | ||
| :: a [=string=] defining the domain or domain pattern that must match for this scope specification to apply | ||
| : <dfn>domain</dfn> | ||
| :: a [=string=] defining the domain or domain pattern that must match for this scope specification to apply. |
Collaborator
There was a problem hiding this comment.
nit: the entries above and below this don't have a period at the end
Collaborator
Author
There was a problem hiding this comment.
Hm, none of the entries have periods. I guess we can skip it here too.
It's confusing that the JSON key is "domain" abut we call it "host pattern". Since these patterns only match domains anyway, just rename it.
drubery
force-pushed
the
push-rpqrmnmxmykk
branch
from
4af0b60 to
de30122
Compare
github-actions bot
added a commit
that referenced
this pull request
Feb 13, 2026
SHA: 335e903 Reason: push, by drubery Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's confusing that the JSON key is "domain" but we call it "host pattern". Since these patterns only match domains anyway, just rename it.