Allow allocationSize/copyTo on format-less VideoFrames with explicit format#923
Open
Allow allocationSize/copyTo on format-less VideoFrames with explicit format#923
Conversation
Contributor
Author
|
addressing issue #920 |
Contributor
Author
|
@padenot please take a look |
dalecurtis
approved these changes
Mar 10, 2026
Contributor
dalecurtis
left a comment
dalecurtis
left a comment
There was a problem hiding this comment.
I double checked that the rest of the parse algorithm seems to already correctly use the options.format value.
|
LGTM |
baylesj
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates allocationSize and copyTo algorithms to support VideoFrames with
null internal format (e.g. opaque sources) when a destination format is
explicitly provided in options.
Also fixes missing closing tags in Security and Privacy sections.