Fix HMAC JWK import key "use" check

[panva]

Refs #412

---

Preview | Diff

[Frosne]

Just out of curiosity, if usages are empty, what do we do?

Sorry :)

[panva]

Just out of curiosity, if usages are empty, what do we do?

The language reads as don't throw to me. Does it make sense? No, but I probably lack the original context and idea behind these checks.

[Frosne]

not only don't throw, but also don't check for the use field of JWK IIUC

I think I opened Pandora's Box with the JWK use field discussion. Oh well.

[panva]

Some digging through the archives

• Bug 27601 - Inconsistent enforcement of JWK's "use" versus "key_ops" during public key import #64
• Fix #64: Ignore 'use' field in JWK import with empty usages #100

[panva]

not only don't throw, but also don't check for the use field of JWK IIUC

Yeah.

[Frosne]

I'd have put something in the lines "the use field of jwk should be consistent with the usage field"

[twiss]

👍 Thanks for the PR!

The language reads as don't throw to me. Does it make sense? No, but I probably lack the original context and idea behind these checks.

I also don't think it makes sense but I'll open a separate issue for that.