Skip to content

Allow applying preload scripts to opened contexts#803

Draft
OrKoN wants to merge 2 commits into
mainfrom
orkon/preload-script-inheritance
Draft

Allow applying preload scripts to opened contexts#803
OrKoN wants to merge 2 commits into
mainfrom
orkon/preload-script-inheritance

Conversation

@OrKoN

@OrKoN OrKoN commented Oct 25, 2024

Copy link
Copy Markdown
Contributor

This change allows specifying that a specific preload script should apply not only to the specified contexts and but also to all contexts opened by the specified contexts (recursively).

Issue #756


Preview | Diff

@OrKoN
OrKoN force-pushed the orkon/preload-script-inheritance branch from 377aa58 to b13c1de Compare October 25, 2024 12:41
@OrKoN
OrKoN marked this pull request as ready for review October 25, 2024 12:43
@OrKoN OrKoN added the needs-discussion Issues to be discussed by the working group label Oct 25, 2024
@OrKoN
OrKoN requested a review from sadym-chromium October 25, 2024 12:44
@whimboo

whimboo commented Oct 25, 2024

Copy link
Copy Markdown
Contributor

This needs new tests as well, right?

Comment thread index.bs Outdated
Comment thread index.bs Outdated
@css-meeting-bot

Copy link
Copy Markdown
Member

The Browser Testing and Tools Working Group just discussed Allow applying preload scripts to opened contexts.

The full IRC log of that discussion <AutomatedTester> topic: Allow applying preload scripts to opened contexts
<AutomatedTester> github: https://github.com//pull/803
<AutomatedTester> orkon: this is one of the. topics that was brought up by the playwright folks
<jgraham> q+
<AutomatedTester> ... this is the PR that prepared to implements inheritance for preload scripts
<sadym> q+
<AutomatedTester> ... I wonder if there are concerns with this approach and would this have an issue with the events being sent out?
<AutomatedTester> ack next
<AutomatedTester> jgraham: I think we shouild do this
<AutomatedTester> ... we should be looking to add global configuration or top level traversibles be documented
<AutomatedTester> ... I agree we should be doing this but I think we need to be aware of all the different ways that we should bve doing this
<AutomatedTester> q?
<AutomatedTester> ack next
<AutomatedTester> sadym: this looks like a new mechanism. I wonder if this playwright appraoch could not be handled with using preload script globally
<AutomatedTester> jgraham: I think it could but that might be harder
<AutomatedTester> ... people would want it a per context and I think we want it inheritable. They are both required
<AutomatedTester> q?

@OrKoN
OrKoN requested a review from jgraham December 10, 2024 08:33
@OrKoN OrKoN removed the needs-discussion Issues to be discussed by the working group label Dec 10, 2024
@OrKoN
OrKoN marked this pull request as draft December 20, 2024 13:35
@sadym-chromium

Copy link
Copy Markdown
Contributor

I assume the original issue is addressed by #862

@OrKoN

OrKoN commented Jan 30, 2025

Copy link
Copy Markdown
Contributor Author

As we discussed in the WG meeting, we likely want to have both features but the user context feature has more priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants